[PWGDQ] Code cleanup and logic improvements for muon processing in tableMaker(MC)_withAssoc - #17893
Merged
Merged
Conversation
mcoquet642
commented
Sep 13, 2026
mcoquet642
commented
Collaborator
- Removing unused functions
- FillPropagateMuon : removing computation of Rabs (already done in AOD), moving computation on pDCA to FillTrackCollision
- Muon dca x/y is computed in FillTrackCollision for global and standalone muons, and in refit functions for global muons
- Removing PV shift options from MC tableMaker
- Remvoing manual Z shift from tableMaker
mcoquet642
requested review from
XiaozhiBai,
alibuild,
iarsene and
mguilbau
as code owners
September 13, 2026 08:39
|
O2 linter results: ❌ 159 errors, |
mcoquet642
changed the title
mcoquet642
enabled auto-merge (squash)
September 13, 2026 12:43
alibuild
approved these changes
Sep 13, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @mcoquet642.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.