[PWGEM,Photon] move remaining CCDB fetches to CCDB columns - #18038
Draft
mhemmer-cern wants to merge 1 commit into
Draft
mhemmer-cern wants to merge 1 commit into
mhemmer-cern wants to merge 1 commit into
Conversation
github-actions
Bot
added
pwgem
datamodel
photon
|
O2 linter results: ❌ 0 errors, |
Replace per-task BasicCCDBManager queries with declarative CCDB columns, and drop CCDB-manager leftovers from tasks that already read columns. Migrations: - calibTaskEmc: BadChannelMap from aod::EmEmcalObjects - pairQcTask, dalitzEEQC, dalitzEEQCMC: GRPMagField from aod::EmMagFields; drop the GRPObject path, skipGRPOquery, grpPath, grpmagPath, ccdb-url - CheckMCV0: GRPMagField + MatLUT from aod::PcmObjects and the shared aod::GeomCCDBObjects; the LUT pointer is set for every collision, the magnetic field is still installed once per run - photonhbt: GRPMagField from aod::EmMagFields, TPC VDrift from a new aod::EmTpcObjects table (EventTables.h, reusing ccdbTpc::VDriftTgl) Cleanup (no behaviour change): remove the unused CCDB manager, its setup and the now-unused ccdb-url/skipGRPOquery/grpmagPath options from Pi0EtaToGammaGamma(MC).h, TaggingPi0(MC).h, pcmQC, photonResoTask, prefilterPhoton and skimmerPrimaryElectronFromDalitzEE (the skimmer keeps the manager for the TOF response). ccdb-url is kept where it feeds the V0 ML models. Behaviour changes in photonhbt: - VDrift is now taken at each event's timestamp instead of mid-run (getForRun), so it follows changes within a run - a missing VDrift object is now fatal instead of a warning Not migrated: SP resolution (taskPhotonFlow, taskPi0FlowEMC) and nonLinProducer (optional objects from user paths set per wagon), photonconversionbuilder (LUT/geometry loaded once in init), Legacy/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Also add asymmetric-energy-cut to `taskPi0FlowEMC .cxx` for EMCal EMCal cluster pairings.
mhemmer-cern
force-pushed
the
photon-flow
branch
from
September 24, 2026 09:47
7d1393d to
af0c166
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace per-task BasicCCDBManager queries with declarative CCDB columns, and drop CCDB-manager leftovers from tasks that already read columns.
Migrations:
Cleanup (no behaviour change): remove the unused CCDB manager, its setup and the now-unused ccdb-url/skipGRPOquery/grpmagPath options from Pi0EtaToGammaGamma(MC).h, TaggingPi0(MC).h, pcmQC, photonResoTask, prefilterPhoton and skimmerPrimaryElectronFromDalitzEE (the skimmer keeps the manager for the TOF response). ccdb-url is kept where it feeds the V0 ML models.
Behaviour changes in photonhbt:
Not migrated: SP resolution (taskPhotonFlow, taskPi0FlowEMC) and nonLinProducer (optional objects from user paths set per wagon), photonconversionbuilder (LUT/geometry loaded once in init), Legacy/.
Also add asymmetric-energy-cut to
taskPi0FlowEMC .cxxfor EMCal EMCal cluster pairings.