Skip to content

[PWGEM] Store the mixing categories if flag is true - #18111

Open
amaringarcia wants to merge 2 commits into
AliceO2Group:masterfrom
amaringarcia:master
Open

amaringarcia wants to merge 2 commits into
AliceO2Group:masterfrom
amaringarcia:master

Conversation

@amaringarcia

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added pwgem photon Photon and neutral meson PAG label labels Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 238 warnings, 🔕 7 disabled

@github-actions github-actions Bot changed the title Store the mixing categories if flag is true [PWGEM] Store the mixing categories if flag is true Sep 29, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 272ec9b at 2026-09-29 21:41:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/f61c168600290dad66b25600bfed74e1a8f6783f/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/Utils/NMHistograms.h:38:42: error: no header providing "M_PI" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@mhemmer-cern

Copy link
Copy Markdown
Collaborator

Hi Ana, thank you for the PR.
Regarding the code-check error, could you please use the pi and fractions of pi from the common constants defined here:
https://github.com/AliceO2Group/AliceO2/blob/dev/Common/Constants/include/CommonConstants/MathConstants.h.

Regarding the formatting, please have a look at the pre-commit utility package, that can help automate formatting fixes locally before committing: https://aliceo2group.github.io/analysis-framework/docs/tools/#pre-commit-hooks

@alibuild

alibuild commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 8b01763 at 2026-10-02 18:47:

No log files found

Full log here.

@alibuild

alibuild commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8b01763 at 2026-10-02 18:48:

No log files found

Full log here.

@alibuild

alibuild commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 8b01763 at 2026-10-02 18:50:

No log files found

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem

Development

Successfully merging this pull request may close these issues.

3 participants