Repository navigation
Conversation
|
O2 linter results: ❌ 0 errors, |
EmilGorm
marked this pull request as ready for review
October 20, 2026 18:26
EmilGorm
requested review from
alibuild,
dsarkaralice,
jaelpark,
lauraser,
victor-gonzalez and
wenyaCern
as code owners
October 20, 2026 18:26
EmilGorm
enabled auto-merge (squash)
October 20, 2026 18:31
Collaborator
Collaborator
Collaborator
vkucera
marked this pull request as draft
October 20, 2026 19:45
auto-merge was automatically disabled
October 20, 2026 19:45
Pull request was converted to draft
Collaborator
|
Hi @EmilGorm , your PR does not compile on any platform. How did you test it? |
Collaborator
Author
I only ran a compile check for the modified file, but I see now that there is a linker error that I hadn't caught. I fixed that now, and am checking the full O2Physics compilation before repushing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.