fix(run-queue): handle worker spawn failure gracefully and avoid raw …#39
Open
Adityakk9031 wants to merge 1 commit into
Open
fix(run-queue): handle worker spawn failure gracefully and avoid raw …#39Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
Contributor
Author
|
@divitsheth have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #38
Description
This PR fixes a critical bug where worker subprocess spawn failures (e.g.
OSErrorraised bysubprocess.Popen) during manual lifecycle operations (init,ingest,garden) propagate as raw uncaught Python tracebacks.We now catch spawn errors safely, wrap them in a product-level
ExecutionFailedexception, and present a clean user-facing error message with attach instructions.Detailed Changes:
_spawn_worker_safelyinsrc/codealmanac/workflows/run_queue/service.pyto wrap thespawn_workercalls. If spawning fails, it raises anExecutionFailedexception containing the orphanedrun_idand recovery instructions (codealmanac jobs attach <id>).try/exceptblocks across all three triggers, successfully keeping the service line count under the strict architecture test limit of 200 lines.test_run_queue_start_handles_worker_spawn_failureintests/test_run_queue_workflow.pyto assert that spawn failures raiseExecutionFailedand the run is kept persisted asQUEUEDin the database.Verification
Automated Tests
Ran the pytest suite for architecture invariants and run queue workflows: