26.3 Antalya port - Alternative syntax for cluster functions#1640
26.3 Antalya port - Alternative syntax for cluster functions#1640ianton-ru wants to merge 18 commits intoantalya-26.3from
Conversation
…tive_syntax 26.1 Antalya port - Alternative syntax for cluster functions
…e_for_partitioning 26.1 Antalya port - Timezone for partitioning
…nquoted_timezone Fix unquoted timezone in sorting key
ianton-ru
changed the title
…_initiator Antalya 26.1: Fix remote initiator host name
…itiator_improvements Antalya 26.1: Remote initiator improvements
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88842054aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pure_storage->renameInMemory(new_table_id); | ||
| return; |
There was a problem hiding this comment.
StorageObjectStorageCluster::renameInMemory returns after renaming only pure_storage, but pure_storage is always present, so the wrapper's own storage_id is never updated. After RENAME TABLE, calls that read StorageObjectStorageCluster::getStorageID() can still see the old identifier, which can break catalog/dependency logic that relies on the storage object reporting its current name.
Useful? React with 👍 / 👎.
| static pcg64 rng(randomSeed()); | ||
| size_t shard_num = rng() % host_addresses.size(); |
There was a problem hiding this comment.
The function keeps a process-wide static pcg64 and advances it on each call. When multiple queries use object_storage_remote_initiator concurrently, they race on this shared RNG state, which is undefined behavior in C++. This can lead to flaky host selection and hard-to-diagnose concurrency issues; use thread_local RNG or guard access with synchronization.
Useful? React with 👍 / 👎.
…rser' into frontport/antalya-26.3/alternative_syntax
|
Test |
| /// controls new feature and it's 'true' by default, use 'false' as previous_value). | ||
| /// It's used to implement `compatibility` setting (see https://github.com/ClickHouse/ClickHouse/issues/35972) | ||
| /// Note: please check if the key already exists to prevent duplicate entries. | ||
| addSettingsChanges(settings_changes_history, "26.3.1.20001.altinityantalya", |
There was a problem hiding this comment.
I am making an update for our settingschangeshistory.
I will later ask you to move all your settings to a corresponding section: whether they appeared in 25.8, in 26.1 or in any other version. It is not correct to put them all into the latest release block, we won't do this anymore
There was a problem hiding this comment.
It will have commented lines for all settings that existed in 26.1. In future, you will add new settings, but for forward-ports you will uncomment corresponding lines
3 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Frontports for Antalya 26.3
CI/CD Options
Exclude tests:
Regression jobs to run: