Repository navigation
Check failed
There are 4 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | 62fabfd | Update contrib/datasketches-cpp to 5.2.0 and backp... | Valid sign-off found |
| 🟢 | 8cd0586 | Add uniqApacheHLL: Apache DataSketches HLL as a na... | Valid sign-off found |
| 🟢 | c1d107c | Merge branch 'antalya-26.6' into feature/antalya-2... | Skipped: sign-off not required in merge commit |
| 🟢 | 9c9c7fb | Simplify uniqApacheHLL implementation and tests |
Skipped: sign-off not required for members |
| 🟢 | 562352f | Fix uniqApacheHLL merge resolution below 7 and e... |
Skipped: sign-off not required for members |
| 🟢 | a6477a1 | Merge branch 'antalya-26.6' into feature/antalya-2... | Skipped: sign-off not required in merge commit |
| 🟢 | 81fb83c | Fix uniqApacheHLL on an all-NULL argument and me... |
Skipped: sign-off not required for members |
| 🔴 | 00dbe28 | ci: run aggregate functions regression | Sign-off not found |
| 🔴 | a626ce8 | Defer folding in uniqApacheHLL and add missing i... |
Sign-off not found |
| 🔴 | 516fd39 | Make uniqApacheHLL reject non-integer lg_k and... |
Sign-off not found |
| 🔴 | 5cc6aaa | Remove stray blank line in `AggregateFunctionUniqA... | Sign-off not found |
| 🟢 | 2440dbe | Use FieldVisitorConvertToNumber for the `uniqApa... |
Valid sign-off found in remediation commit |
| 🟢 | 12c65dd | Include config.h explicitly where `USE_DATASKETC... |
Valid sign-off found in remediation commit |
| 🟢 | b403cd0 | Update contrib/datasketches-cpp to include the c... |
Valid sign-off found in remediation commit |
| 🟢 | 629b427 | Merge branch 'antalya-26.6' into feature/antalya-2... | Skipped: sign-off not required in merge commit |
| 🟢 | 254c630 | Merge rhs sketches before folding the pending on... |
Valid sign-off found in remediation commit |
| 🟢 | 31e9e7a | Add a test pinning how uniqApacheHLL hashes ever... |
Valid sign-off found in remediation commit |
| 🟢 | 8d49460 | Ignore empty strings in uniqApacheHLL and pin it... |
Valid sign-off found in remediation commit |
| 🟢 | 30ad260 | Keep the uniqApacheHLL state of a Nullable arg... |
Valid sign-off found in remediation commit |
| 🟢 | a30cd57 | Give the uniqApacheHLL state of a Nullable arg... |
Valid sign-off found in remediation commit |
| 🟢 | 2033e7b | Let a function opt out of the flag and type of the... | Valid sign-off found in remediation commit |
| 🟢 | e99077e | Merge branch 'feature/antalya-26.6/uniq-apache-hll... | Skipped: sign-off not required in merge commit |
| 🟢 | 71ed5a7 | Fix the expected output of two new uniqApacheHLL... |
Valid sign-off found in remediation commit |
| 🟢 | 1bfd0e1 | DCO remediation commit for UnamedRus <dtitmoav@gma... | Valid sign-off found |
| 🟢 | 970be31 | Stop converting uniqApacheHLL unions to the decl... |
Valid sign-off found |
| 🟢 | 5f06020 | Drop the speculative ordering comment in `uniqApac... | Valid sign-off found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~26 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin feature/antalya-26.6/uniq-apache-hll