Skip to content

Add error message that explains the empty URI scheme instead of a nul… #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subkanthi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add error message that explains the empty URI scheme instead of a nul… #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ice/src/main/java/com/altinity/ice/internal/iceberg/io/SchemeFileIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,21 @@ public void close() {

public DelegateFileIO io(String location) {
String s = scheme(location);
if (s == null) {
throw new IllegalArgumentException(
String.format(
"File location has no URI scheme (expected s3://, file://, gs://, etc.): \"%s\". "
+ "This usually means the create-table request specified a table \"location\" "
+ "without a scheme, or the catalog warehouse is misconfigured.",
location));
}
String impl = SCHEME_TO_FILE_IO.get(s);
Preconditions.checkNotNull(
impl, String.format("unsupported scheme \"%s\": \"%s\"", s, location));
if (impl == null) {
throw new IllegalArgumentException(
String.format(
"Unsupported file location scheme \"%s\": \"%s\". Supported schemes: %s",
s, location, SCHEME_TO_FILE_IO.keySet()));
}
DelegateFileIO io = ioMap.get(impl);
if (io != null) {
return io;
Expand Down
Loading