Skip to content

Added logic to include client-id so calls from the same iceberg clien…#189

Open
subkanthi wants to merge 2 commits into
masterfrom
10-ice-enable-tracing
Open

Added logic to include client-id so calls from the same iceberg clien…#189
subkanthi wants to merge 2 commits into
masterfrom
10-ice-enable-tracing

Conversation

@subkanthi

Copy link
Copy Markdown
Collaborator

closes: #10

@subkanthi subkanthi linked an issue Jul 9, 2026 that may be closed by this pull request
@subkanthi subkanthi marked this pull request as ready for review July 10, 2026 18:01
@subkanthi

Copy link
Copy Markdown
Collaborator Author

Implementation leveraging ThreadLocal MDC so that the requestId will be accessible through out the request

[Incoming Request] ──> [Assigned Thread] ──> [MDC.put("requestId", fromClient or fingerprint )]


┌───────────────────────┐
│ ThreadLocal Map │
│ └─ "requestId" -> "fromClient or fingerprint" │
└───────────────────────┘


[Log Message Triggered] ───────────────> Reads from ThreadLocal Map ──> Log Output


[Request Finishes] ──> [Thread Cleared] ──> [MDC.clear()] ──> [Thread Returns to Pool]

@subkanthi subkanthi requested a review from xieandrew July 10, 2026 18:15
@subkanthi

subkanthi commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

ice* - same clientId fp-64a66201

2026-07-10 16:40:24 [69252629-50/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 954d72f6-d81a-4acf-ac41-54d26637b1cd @token GET v1/config
2026-07-10 16:40:24 [69252629-35/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 2c005ccb-2b0f-40cc-b4a8-2df6d718a785 @token GET v1/namespaces/flowers/tables
2026-07-10 16:40:26 [69252629-36/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 293b92fd-0ca5-4dfa-9ff1-d3201d69f36b @token GET v1/config
2026-07-10 16:40:26 [69252629-37/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 25c4bea6-a333-4f6a-8fb6-5e4347092aca @token GET v1/namespaces/flowers/tables
2026-07-10 16:40:28 [69252629-38/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 48b7f701-f1f3-46d6-b1f3-0625136167f3 @token GET v1/config
2026-07-10 16:40:28 [69252629-33/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 5d34ed2e-ba6c-4ff6-ac72-8b1bd8e5a77d @token GET v1/namespaces/flowers/tables
2026-07-10 16:40:29 [69252629-40/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 ea722685-23e2-41c5-9504-a07fd690cc08 @token GET v1/config
2026-07-10 16:40:29 [69252629-51/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 14855a97-d275-4a95-a98d-7f593432035e @token GET v1/namespaces/flowers/tables
2026-07-10 16:40:30 [69252629-34/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 54619b80-0873-4fcf-b329-a3742699cce3 @token GET v1/config
2026-07-10 16:40:30 [69252629-35/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 90f3b6ba-8155-4cd2-aa64-09dfef51c407 @token GET v1/namespaces/flowers/tables
2026-07-10 16:40:31 [69252629-36/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 e5f58b7f-0be8-4bd5-b9ca-5da483b0e042 @token GET v1/config
2026-07-10 16:40:31 [69252629-37/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 0d02c2e3-51ce-4649-93b5-334fd2270eae @token GET v1/namespaces/flowers/tables
2026-07-10 16:40:32 [69252629-40/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 48d38bb2-f2a8-4821-b2d9-13f61e150c06 @token GET v1/config
2026-07-10 16:40:32 [69252629-51/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 0a16e9f5-e8d3-4315-b71e-c554ba232fee @token GET v1/namespaces/flowers/tables
2026-07-10 16:40:34 [69252629-34/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 e85392f0-5d54-490a-8743-572e7531f939 @token GET v1/config
2026-07-10 16:40:34 [69252629-35/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 d8bccf7a-d057-403e-a11d-e0af22ce0eaf @token GET v1/namespaces/flowers/tables
2026-07-10 16:40:35 [69252629-36/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 a8e75ebe-f713-42a1-a90c-57aaecc0dd4c @token GET v1/config
2026-07-10 16:40:35 [69252629-37/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 b5d9819f-7c2c-4af0-b22a-fd984fd77e5c @token GET v1/namespaces/flowers/tables
2026-07-10 16:40:36 [69252629-40/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 f7dbff2d-c398-47a9-ad9a-362aa44ab6c7 @token GET v1/config
2026-07-10 16:40:36 [69252629-51/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 799e311d-33ed-4529-8539-0e220ef42228 @token GET v1/namespaces/flowers/tables
2026-07-10 16:40:37 [69252629-34/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 491cc657-f246-4fd1-9095-0dc537636ebd @token GET v1/config
2026-07-10 16:40:37 [69252629-35/81889] INFO c.a.i.r.c.i.r.RESTCatalogServlet > fp-64a66201 92bf6f79-f2fb-4621-9d73-d64b7882c550 @token GET v1/namespaces/flowers/tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ice: Enable tracing

1 participant