Skip to content

Fix import error uvicorn.run in serve()#878

Merged
jph00 merged 1 commit intoAnswerDotAI:mainfrom
dienhoa:fix/missing-uvicorn-import
May 10, 2026
Merged

Fix import error uvicorn.run in serve()#878
jph00 merged 1 commit intoAnswerDotAI:mainfrom
dienhoa:fix/missing-uvicorn-import

Conversation

@dienhoa
Copy link
Copy Markdown
Contributor

@dienhoa dienhoa commented May 10, 2026


name: Pull Request
about: Propose changes to the codebase
title: '[PR] '
labels: ''
assignees: ''


Related Issue
#877
In core.py, we have from uvicorn import run, but run with uvicorn.run

Proposed Changes
Replace uvicorn.run with just run in serve()

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

@jph00
Copy link
Copy Markdown
Contributor

jph00 commented May 10, 2026

Thank you! :)

@jph00 jph00 merged commit 948e9b7 into AnswerDotAI:main May 10, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants