fix: anchor Email regex to prevent substring matching & perf: optimize RemoveCharacters via SearchValues - #12
Open
sdwck wants to merge 2 commits into
Open
fix: anchor Email regex to prevent substring matching & perf: optimize RemoveCharacters via SearchValues#12sdwck wants to merge 2 commits into
sdwck wants to merge 2 commits into
Conversation
…e RemoveCharacters via SearchValues
Owner
|
Thanks a lot for this, both changes are genuinely solid. The regex anchor fix is a real bug catch The SearchValues optimization is well done, and it follows the existing conventions closely (StackAllocThreshold, ArrayPool/try-finally pattern, XML docs). I traced through the algorithm by hand and it looks correct, including on consecutive matches. Two small things before merging:
Once those are sorted I'm happy to merge. Thanks again, this is exactly the kind of contribution I was hoping for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Saw your project on Reddit. Really love the focus on zero-allocation.
I made a couple of improvements:
Benchmark Results
Great work on the library, keep it up!