Repository navigation
build_artifacts.sh: use the tool versions the M-1 platform pins - #10
Merged
Merged
Conversation
… the env's platform Another project on the same machine replaced the plain packages/tool-esptoolpy folder with esptool 4.11.0 and moved the pinned 4.7.4 to a tool-esptoolpy@src-... folder, so the script silently used a different esptool (the merged image happened to be identical). The script now asks PlatformIO for the apollo_m1 platform, reads its pinned package versions from platform.json and uses the matching installed folders, falling back to the plain folders with a warning. BUILD_INFO.txt records which folders were used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Author
|
Verified before merge: on main with b8's web-UI files, the script resolves esptool 4.7.4 from tool-esptoolpy@src-c7ffb851 and its M-1_full_install.bin matches the shipped m1-b8 image except the 65 ELF-fingerprint/checksum bytes. Apollo M-1 build CI: success. The remaining usermods job builds an env this script does not touch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release tooling fix found while packaging the b9 test candidate.
Problem: another project on the same Mac installed esptool 4.11.0 into the plain
~/.platformio/packages/tool-esptoolpyfolder and moved the version our platform pins (4.7.4, tasmota) totool-esptoolpy@src-....apollo/build_artifacts.shhard-coded the plain folder, so it silently used 4.11.0. The same can happen toframework-arduinoespressif32(boot_app0.bin) andtool-mklittlefs; this Mac has 14 different espressif32 platforms installed.Fix: the script asks PlatformIO for the
apollo_m1env's platform (pio project config), reads that platform's pinned package versions from itsplatform.json, and uses the installed folders whose.piopmmatches. Falls back to the plain folders with a warning.BUILD_INFO.txtnow records which folders were used.Verified: on
mainwith b8's web-UI files, the script pickstool-esptoolpy@src-c7ffb851...(4.7.4) and itsM-1_full_install.binmatches the shipped m1-b8 image except the 65 ELF-fingerprint/checksum bytes in the app. esptool 4.7.4 and 4.11.0 also produce identical merged images for the same parts, so nothing shipped or tested so far is affected. No firmware change.🤖 Generated with Claude Code