Skip to content

b9 draft: upstream 16.x fixes incl. security advisory GHSA-rrjq-j36x-xrpq - #6

Open
Bunton33 wants to merge 5 commits into
mainfrom
b9/upstream-16x-fixes
Open

Bunton33 wants to merge 5 commits into
mainfrom
b9/upstream-16x-fixes

Conversation

@Bunton33

Copy link
Copy Markdown

Draft for bundle b9. Do not merge until Justin decides the scope and the hardware gates pass (virgin boot, QA_CHECKLIST D13 AP walkthrough, OTA b8 to b9; see apollo/RELEASE_CHECKLIST.md once #5 is merged).

Why now

Upstream published security advisory GHSA-rrjq-j36x-xrpq (medium, 2026-10-15): an out-of-bounds read on an empty playlist transition array, affecting WLED <= 16.0.1. Bundle b8 ships the vulnerable line unchanged (wled00/playlist.cpp). The M-1 setup hotspot is open by design, so an unconfigured unit is reachable by anyone in WiFi range, and a configured one by anyone on its LAN. Impact is limited (one out-of-bounds read, no write).

There is no upstream v16.0.2 tag yet, so this takes the fixes from upstream's 16.x release line as a recorded exception to "merge release tags only": each commit is a git cherry-pick -x of the upstream commit, so the origin is named in the message.

Commits (all from upstream 16_x, all applied cleanly)

Upstream Fix File
38df4cc (wled#5909) Security: OOB playlist transition read playlist.cpp
4ee90bd (wled#5866) Reconnect when the AP SSID changes (condition was inverted) set.cpp
bd31a83 (wled#5736) Create a default segment when out of heap FX_fcn.cpp
c39d929 (wled#5726) On/off transition flick FX_fcn.cpp
2d738c8 (wled#5733) uint8 underflow in the AP client disconnect handler network.cpp

Each is a separate commit, so any of the last four can be dropped if b9 should be security-only.

Not included: wled#5828 (069a676) does not apply to this tree, and the M-1 already carries its own fixes for both bugs it addresses.

Checked so far

🤖 Generated with Claude Code

npabisz and others added 5 commits October 22, 2026 01:06
* fix: prevent uint8 underflow in AP client disconnect handler

Add bounds check before decrementing apClients to prevent
wraparound from 0 to 255 when WiFiEvent fires disconnect
without a prior connect event.

Also fix typo: awailable -> available

(cherry picked from commit 2d738c8)
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TrevorSchirmer
TrevorSchirmer marked this pull request as ready for review October 22, 2026 21:51
@Bunton33
Bunton33 changed the base branch from m1-wled-update to main October 23, 2026 00:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants