Repository navigation
Conversation
(cherry picked from commit c39d929)
* fix: prevent uint8 underflow in AP client disconnect handler Add bounds check before decrementing apClients to prevent wraparound from 0 to 255 when WiFiEvent fires disconnect without a prior connect event. Also fix typo: awailable -> available (cherry picked from commit 2d738c8)
(cherry picked from commit bd31a83)
(cherry picked from commit 4ee90bd)
Advisory by @redhotchilihacker1 (cherry picked from commit 38df4cc)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TrevorSchirmer
marked this pull request as ready for review
October 22, 2026 21:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for bundle b9. Do not merge until Justin decides the scope and the hardware gates pass (virgin boot, QA_CHECKLIST D13 AP walkthrough, OTA b8 to b9; see apollo/RELEASE_CHECKLIST.md once #5 is merged).
Why now
Upstream published security advisory GHSA-rrjq-j36x-xrpq (medium, 2026-10-15): an out-of-bounds read on an empty playlist
transitionarray, affecting WLED <= 16.0.1. Bundle b8 ships the vulnerable line unchanged (wled00/playlist.cpp). The M-1 setup hotspot is open by design, so an unconfigured unit is reachable by anyone in WiFi range, and a configured one by anyone on its LAN. Impact is limited (one out-of-bounds read, no write).There is no upstream v16.0.2 tag yet, so this takes the fixes from upstream's 16.x release line as a recorded exception to "merge release tags only": each commit is a
git cherry-pick -xof the upstream commit, so the origin is named in the message.Commits (all from upstream
16_x, all applied cleanly)Each is a separate commit, so any of the last four can be dropped if b9 should be security-only.
Not included: wled#5828 (069a676) does not apply to this tree, and the M-1 already carries its own fixes for both bugs it addresses.
Checked so far
pio run -e apollo_m1): SUCCESS, flash 1,250,513 bytes (b8: 1,250,461), RAM unchanged.🤖 Generated with Claude Code