Skip to content

ci: make the PNG resize step work; remove unused installer screenshots - #1177

Merged
Bunton33 merged 1 commit into
devfrom
chore/resize-images-and-cleanup
Oct 19, 2026
Merged

Bunton33 merged 1 commit into
devfrom
chore/resize-images-and-cleanup

Conversation

@Bunton33

Copy link
Copy Markdown
Contributor

Resize step: The deploy's resize step (ci.yml) has never resized anything. In bash -c 'mogrify -resize '750x>' "$1"', the unquoted > is read as a shell redirect, so mogrify gets no file and its output goes into a stray file. As a result, 341 PNGs wider than 750 px (413 MB in the repo, including 4096×4096 Starter Kit renders of 20 to 30 MB each) have been published at full size. Quoting the geometry ("750x>") makes the step shrink every PNG wider than 750 px for the published site. The repo keeps the originals.

Tested with a stand-in mogrify under bash -eo pipefail, the way GitHub Actions runs it:

  • Old line: never received a file, and created the stray file.
  • New line: receives -resize 750x> <file> for every PNG, including filenames with spaces.

Cleanup:

  • Removes the 15 old installer and ESP Flasher screenshots, plus docs/static/ESP-Flasher.exe (16 MB). Nothing in the wiki, mkdocs.yml or other Apollo repos links them since the reflash guides moved to install.apolloautomation.com.
  • Adds temp-pro-1-product.jpg (600×600), the product image for the TEMP Pro-1 page being added to the installer.

Checks: markdown, secrets and images 0; check_links 683 pages and 3,163 of 3,149 expected images, 0 errors.

🤖 Generated with Claude Code

The deploy's resize step never resized anything: in
`bash -c 'mogrify -resize '750x>' "$1"'` the unquoted > was a shell
redirect, so mogrify got no file and the output went to a stray file.
341 PNGs wider than 750 px (413 MB, including 4096x4096 Starter Kit
renders of 20 to 30 MB) were published at full size. Quote the geometry
so PNGs wider than 750 px are shrunk for the published site; the repo
keeps the originals.

Also:
- Remove 15 old installer and ESP Flasher screenshots and
  docs/static/ESP-Flasher.exe (16 MB). Nothing in the wiki links them
  since the reflash guides moved to the new installer.
- Add temp-pro-1-product.jpg (600x600), the product image for the
  TEMP Pro-1 page being added to install.apolloautomation.com.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 01235add-0a12-417d-80c2-0b17184b0fa3
📥 Commits

Reviewing files that changed from the base of the PR and between 3591a58 and 77dc77d.

⛔ Files ignored due to path filters: 17
  • docs/assets/air-1-reflash-pic-1.png is excluded by !**/*.png
  • docs/assets/btn-1-reflash-installer-connect.gif is excluded by !**/*.gif
  • docs/assets/h-2-reflash-installer-connect.gif is excluded by !**/*.gif
  • docs/assets/m-1-reflash-completed.png is excluded by !**/*.png
  • docs/assets/m-1-select-firmware-you-downloaded.png is excluded by !**/*.png
  • docs/assets/m-1-select-open-com-port.png is excluded by !**/*.png
  • docs/assets/msr-1-reflash-pic-1.png is excluded by !**/*.png
  • docs/assets/msr-2-reflash-pic-1.png is excluded by !**/*.png
  • docs/assets/mtr-1-reflash-pic-1.png is excluded by !**/*.png
  • docs/assets/plt-1-reflash-pic-1-1.png is excluded by !**/*.png
  • docs/assets/plt-1b-reflash-pic-1.png is excluded by !**/*.png
  • docs/assets/pump-1-reflash-connect-button.png is excluded by !**/*.png
  • docs/assets/r-pro-1-reflash-connect-button.png is excluded by !**/*.png
  • docs/assets/temp-1-reflash-pic-1-1.png is excluded by !**/*.png
  • docs/assets/temp-1b-reflash-pic-1.png is excluded by !**/*.png
  • docs/assets/temp-pro-1-product.jpg is excluded by !**/*.jpg
  • docs/static/ESP-Flasher.exe is excluded by !**/*.exe
📒 Files selected for processing: 1
  • .github/workflows/ci.yml
+--------------------------------------------------------------+
| 🥕 I brought carrots. You brought corner cases. Let's party. |
+--------------------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Bunton33
Bunton33 merged commit 29198ad into dev Oct 19, 2026
2 of 3 checks passed
@Bunton33
Bunton33 deleted the chore/resize-images-and-cleanup branch October 19, 2026 23:08
This was referenced Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants