Repository navigation
ci: make the PNG resize step work; remove unused installer screenshots - #1177
Merged
Merged
Conversation
The deploy's resize step never resized anything: in `bash -c 'mogrify -resize '750x>' "$1"'` the unquoted > was a shell redirect, so mogrify got no file and the output went to a stray file. 341 PNGs wider than 750 px (413 MB, including 4096x4096 Starter Kit renders of 20 to 30 MB) were published at full size. Quote the geometry so PNGs wider than 750 px are shrunk for the published site; the repo keeps the originals. Also: - Remove 15 old installer and ESP Flasher screenshots and docs/static/ESP-Flasher.exe (16 MB). Nothing in the wiki links them since the reflash guides moved to the new installer. - Add temp-pro-1-product.jpg (600x600), the product image for the TEMP Pro-1 page being added to install.apolloautomation.com. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 17
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resize step: The deploy's resize step (
ci.yml) has never resized anything. Inbash -c 'mogrify -resize '750x>' "$1"', the unquoted>is read as a shell redirect, somogrifygets no file and its output goes into a stray file. As a result, 341 PNGs wider than 750 px (413 MB in the repo, including 4096×4096 Starter Kit renders of 20 to 30 MB each) have been published at full size. Quoting the geometry ("750x>") makes the step shrink every PNG wider than 750 px for the published site. The repo keeps the originals.Tested with a stand-in
mogrifyunderbash -eo pipefail, the way GitHub Actions runs it:-resize 750x> <file>for every PNG, including filenames with spaces.Cleanup:
docs/static/ESP-Flasher.exe(16 MB). Nothing in the wiki,mkdocs.ymlor other Apollo repos links them since the reflash guides moved to install.apolloautomation.com.temp-pro-1-product.jpg(600×600), the product image for the TEMP Pro-1 page being added to the installer.Checks: markdown, secrets and images 0; check_links 683 pages and 3,163 of 3,149 expected images, 0 errors.
🤖 Generated with Claude Code