Skip to content

Sync dev to main: Apollo mmWave switch-over steps and zone map caveats - #1193

Merged
Bunton33 merged 1 commit into
mainfrom
dev
Oct 25, 2026
Merged

Bunton33 merged 1 commit into
mainfrom
dev

Conversation

@Bunton33

Copy link
Copy Markdown
Contributor

Publishes #1192: how to switch HACS from the original Apollo mmWave repository without losing zones, plus zone map, help-link and R PRO-1 wording fixes in the Apollo mmWave dashboard guides.

🤖 Generated with Claude Code

…p caveats (#1192)

* Add switch-over steps from the original Apollo mmWave repository

The setup guide's upgrade section gains a subsection for installs from
the original repository, bharvey88/apollo-mmwave, which is no longer on
GitHub: remove its Custom repositories row, add
ApolloAutomation/apollo-mmwave-main, download and restart. Two warnings
cover deleting the integration entry and pressing Remove or Redownload
in HACS. The section now also says to take a backup first and to
restart and refresh after an update, and the install section points
old installs at the new subsection.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Match the help card's Full tuning guide link to the dashboard code

The link on an MSR-1 or MSR-2 opens the general version of the tuning
guide (profiles.ts LD2410 wikiUrl), not the MSR-2 guide. On an R PRO-1
it opens the R PRO-1 version at its LD2412 section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Cover both Auto-calibrate states on an R PRO-1 without the LD2412

Without the addon the card either shows the radar as offline with its
buttons disabled (calibrate-card.ts _online) or refuses the run with
"The radar has not reported 28 of its threshold values yet." The LD2412
check covers all 28 thresholds (calibration.py _chip_sent_thresholds),
so the old 18 was the MSR count. Either way the zone map is what that
sensor uses. The note moves out of the threshold bullet into its own
paragraph, and the bullet now says the count is up to 18 or 28.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Add zone map touch, lock and offline presence caveats

The lock stops drawing only (zone-map/card.ts startDrawing and draw);
Clear All Zones, a double-click on a zone button, undo and Configure ->
Zones still change zones. The grid takes every touch (touch-action:
none and preventDefault on the canvas, locked or not), so scroll the
page outside it on a phone and keep the map locked. Zone presence reads
off, not unavailable, while the radar is offline (binary_sensor.py,
docs/configuration.md "Zones in automations").

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Point zone map scrolling at the radar's name, not the zone buttons

The zone button row also holds Clear All Zones, which works while the
map is locked and asks for no confirmation. Telling phone users to
scroll there risks a stray tap clearing every zone's shape. The radar's
name above the grid is a safe place to scroll.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Make the switch-over carry-over promise conditional on what you have

The intro said the entry, dashboard, zones, Undo values and entity IDs
all carry over with no condition. That is not true for every old
version: Undo only exists from 2.2.0, and on 1.x zones of a renamed
radar are kept but not shown. Say that what you already have carries
over, and mark the 1.x or 2.0 paragraph as the exception.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Say HACS tracks Apollo mmWave updates, not that it installs them

"HACS updates Apollo mmWave" reads as if HACS installs updates on its
own. HACS 2.0.5 only offers them. Match the install section's wording
("tracks updates") and have the reader do the update.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Link the switch-over backup step to the backup instructions

Step 1 said to back up "as described at the start of this section", but
the backup text and button sit at the start of the parent section.
Readers who follow the link from the install section land on the
subsection and never see them. Give the path and link the section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Put the reopen-dialog condition first in switch-over step 4

Step 4 listed paste, set type, add and close, then said to reopen
Custom repositories first if the dialog had closed. A precondition
that comes after the actions it gates is easy to miss.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Link the help card's R PRO-1 target to the R PRO-1 page

The sentence says the help card opens the R PRO-1 version of the guide,
but the link was an in-page anchor. The general page is included into
every product copy, so on the general, MSR-1, MSR-2 and MTR-1 pages it
went to that page's own section. Point it at the R PRO-1 page, the
same place the card's link (profiles.ts) opens.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Retitle the switch-over warnings positively

Both warning titles started with "Don't", next to a "Don't:" in the
box and a "don't restart" in step 5. The style guide asks to rephrase
excessive "no" framing positively, and the page's other warnings
already do ("Keep Zone Mapper until your zones have moved over"). The
box text is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Add the Restart confirmation to the install section's restart step

Choosing Restart Home Assistant opens a confirmation dialog
(ui.dialogs.restart.restart.confirm_action, "Restart"). The new
switch-over step 7 already says to click Restart; the install step
left it out, so the page gave two versions of the same restart.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 1
  • beta

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 27d69f8c-31f0-42ec-8b45-814e7387a215

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Bunton33
Bunton33 merged commit 6761c61 into main Oct 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants