Repository navigation
TEMP-1: add Revision 1 options (support only) - #32
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks done
Bunton33
changed the title
5 tasks done
USB Power (R1, support only) flashes firmware/ (TEMP-1.yaml) and Battery Power (R1, support only) flashes firmware-b/ (TEMP-1B.yaml), after the Revision 2 defaults, which stay selected first. The revisions differ in the Food Probe divider (source_sensor_resistance 100k vs 3.3k), so the wrong build reads far off, and OTA keeps following whichever build is installed. The variant notes say this and send anyone unsure back to the default. Rebuilt from main: the TEMP_PRO-1, AIR-1/MSR-2 and CSS parts of the original commit shipped in #33. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bunton33
force-pushed
the
feat/temp-pro-1-and-fixes
branch
from
October 23, 2026 00:10
31e1290 to
11bb5f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the two TEMP-1 Revision 1 builds as support-only options, after the Revision 2 defaults, which stay selected first. This lets the wiki point Revision 1 owners at this installer instead of the classic page.
firmware2/(unchanged)TEMP-1_R2.yamlfirmware-b2/(unchanged)TEMP-1B_R2.yamlfirmware/TEMP-1.yamlfirmware-b/TEMP-1B.yamlsource_sensor_resistance: 100k for R1, 3.3k for R2), so the wrong build makes the probe read far off.The decision to make: offer R1 here at all, or keep it on the classic page only. On a phone, TEMP-1 now shows four variant buttons;
.segwraps them (checked at 360px).Rebuilt on 2026-10-22. The branch was recreated from
mainwith only thisdevices.jsonhunk and force-pushed. The earlier head (31e1290) also carried the TEMP_PRO-1, AIR-1/MSR-2 and CSS changes that shipped in #33. Merging that head would have added a second TEMP_PRO-1 entry, which a rebase didn't remove. The diff againstmainis nowdevices.json+14/−2.Checklist
cd tests && npx playwright test): 42 passed, including the every-device-and-variant and 360px checkscplist in.github/workflows/pages.yml: none addeddevices.jsonchanged:python scripts/validate_registry.pypasses ("Registry OK: all manifests live and complete.")firmware/andfirmware-b/are both on the TEMP-1 classic installer page (the validator checks this), eachconfigis the YAML that builds it, and R2 stays the default🤖 Generated with Claude Code