fix(integrations): derive "coming soon" from whether a page exists - #1116
Closed
avoguru wants to merge 1 commit into
Closed
fix(integrations): derive "coming soon" from whether a page exists#1116avoguru wants to merge 1 commit into
avoguru wants to merge 1 commit into
Conversation
The index took `isComingSoon` from the design-system catalog, a hand-maintained constant in a published package. It goes stale the moment a toolkit ships, so a live toolkit keeps rendering as an unavailable card. Snowflake is in that state now: its docs generated and merged in #1114, but the tile still reads "Coming soon". Resolve the flag in `resolveIndexToolkits` from `hasPage` instead. The badge means "there is nothing to read yet", which is exactly what `hasPage` already answers, and the value no longer depends on a package release. This also makes the badge and the sort order agree. `use-toolkit-filters` sorted on the raw design-system flag while the card rendered on `isComingSoon || !hasPage`, so seven toolkits (CloseIO, Discord, GoogleForms, Notion, Obsidian, Twilio, Twitch) showed a "Coming soon" badge while sorting among the available ones. They now sort with the other unavailable toolkits. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Folded into #1115 — the auth provider page and this fix belong together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Snowflake tile still reads "Coming soon" even though its docs generated and merged in #1114.
The index took
isComingSoonfrom the design-system catalog, which is a hand-maintained constant in a published package. It goes stale the moment a toolkit ships, and the generator copies it straight into the toolkit JSON, so a nightly run keeps writing it back.This derives the flag from
hasPageinstead. The badge means "there is nothing to read yet", which is whathasPagealready answers, and it no longer waits on a package release. One tile changes: Snowflake.It also makes the badge and the sort agree.
use-toolkit-filterssorted on the raw design-system flag while the card rendered onisComingSoon || !hasPage, so seven toolkits (CloseIO, Discord, GoogleForms, Notion, Obsidian, Twilio, Twitch) showed a "Coming soon" badge while sorting among the available ones. They now sort with the other unavailable toolkits.Verified locally: the Snowflake card renders "Arcade Optimized MCP Server" with no badge and links through to the toolkit page. Every entry now satisfies
isComingSoon === !hasPage. 796 tests pass.The design-system entry is still stale (
isComingSoon: true,category: "development") and worth correcting separately, but the docs site no longer depends on it for this.🤖 Generated with Claude Code
Note
Low Risk
Small display/sort fix on the integrations index; no auth, data, or API changes.
Overview
Coming soon on the integrations index is now
isComingSoon: !hasPageinresolveIndexToolkits, instead of the design-system catalog flag that can staytrueafter docs ship (e.g. Snowflake).ToolkitsClientpassestoolkit.isComingSoononly—it no longer ORs withhasPage === false, because resolution already aligns badge, click behavior, anduse-toolkit-filterssort on the same value.Reviewed by Cursor Bugbot for commit 3903d32. Bugbot is set up for automated code reviews on this repo. Configure here.