This repository was archived by the owner on Oct 27, 2026. It is now read-only.
Repository navigation
refactor(integrations): stop listing the community designation #1252
Open
samkujovich
wants to merge
6
commits into
fix/integrations-index-from-public-catalog
Choose a base branch
from
chore/design-system-8
base: fix/integrations-index-from-public-catalog
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−54
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7983382
refactor(integrations): stop listing the community designation
samkujovich bc47543
Merge branch 'fix/integrations-index-from-public-catalog' into chore/…
samkujovich 0e43a4e
Merge branch 'fix/integrations-index-from-public-catalog' into chore/…
samkujovich a1af357
Merge branch 'fix/integrations-index-from-public-catalog' into chore/…
samkujovich 6c0549a
Merge branch 'fix/integrations-index-from-public-catalog' into chore/…
samkujovich ff917da
Merge branch 'fix/integrations-index-from-public-catalog' into chore/…
samkujovich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,18 +9,25 @@ const TOOLKIT_CATEGORIES: readonly ToolkitCategory[] = CATEGORIES.map( | |
| (category) => category.id | ||
| ); | ||
|
|
||
| /** | ||
| * The designations the index presents. `community` is still a design-system | ||
| * ToolkitType, but no toolkit is assigned it. | ||
| */ | ||
| export type ListedToolkitType = Exclude<ToolkitType, "community">; | ||
|
|
||
| // ToolkitType has no runtime export from the design system, so this list is | ||
| // hand-maintained. `satisfies` turns a missing or extra entry into a | ||
| // compile error the next time the union changes, instead of a silent drop. | ||
| const TOOLKIT_TYPE_MEMBERSHIP = { | ||
| arcade: true, | ||
| arcade_starter: true, | ||
| verified: true, | ||
| community: true, | ||
| auth: true, | ||
| } satisfies Record<ToolkitType, true>; | ||
| } satisfies Record<ListedToolkitType, true>; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can avoid all these changes by renaming it in the DS.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same fix as the thread above: once ArcadeAI/monorepo#5987 publishes 8.0.0, these changes collapse to plain deletions. ~ 🤖 sam-i-am, Sam’s Agent |
||
|
|
||
| const TOOLKIT_TYPES = Object.keys(TOOLKIT_TYPE_MEMBERSHIP) as ToolkitType[]; | ||
| const TOOLKIT_TYPES = Object.keys( | ||
| TOOLKIT_TYPE_MEMBERSHIP | ||
| ) as ListedToolkitType[]; | ||
|
|
||
| export const PARAM_CATEGORY = "category"; | ||
| export const PARAM_TYPE = "type"; | ||
|
|
@@ -38,7 +45,7 @@ export function isLabel(value: string): value is Label { | |
|
|
||
| export type FilterState = { | ||
| selectedCategory: ToolkitCategory; | ||
| selectedType: ToolkitType | "all"; | ||
| selectedType: ListedToolkitType | "all"; | ||
| filterByPro: boolean; | ||
| filterByByoc: boolean; | ||
| searchQuery: string; | ||
|
|
@@ -52,7 +59,7 @@ export const DEFAULT_FILTER_STATE: FilterState = { | |
| searchQuery: "", | ||
| }; | ||
|
|
||
| export function isToolkitType(value: string): value is ToolkitType { | ||
| export function isToolkitType(value: string): value is ListedToolkitType { | ||
| return (TOOLKIT_TYPES as readonly string[]).includes(value); | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably remove community from the design system as well, so we don't need to do this here. We can merge that PR first and update this one if that is ok with you, @samkujovich
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We're doing it your way. ArcadeAI/monorepo#5987 removes
communityfrom design-system (8.0.0) and from the monorepo copy of the docs site; no toolkit uses it since ArcadeAI/monorepo#5732. Once 8.0.0 is on npm, I'll cut this PR down to bumping design-system and deleting thecommunityentries, without theListedToolkitTypeplumbing.~ 🤖 sam-i-am, Sam’s Agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved #5987. You can refactor this one when that one is merged!