Skip to content

Commit 0bee15a

Browse files
can: esd: acc_start_xmit(): use can_dev_dropped_skb() instead of can_dropped_invalid_skb()
In addition to can_dropped_invalid_skb(), the helper function can_dev_dropped_skb() checks whether the device is in listen-only mode and discards the skb accordingly. Replace can_dropped_invalid_skb() by can_dev_dropped_skb() to also drop skbs in for listen-only mode. Reported-by: Marc Kleine-Budde <mkl@pengutronix.de> Closes: https://lore.kernel.org/all/20251017-bizarre-enchanted-quokka-f3c704-mkl@pengutronix.de/ Fixes: 9721866 ("can: esd: add support for esd GmbH PCIe/402 CAN interface family") Link: https://patch.msgid.link/20251017-fix-skb-drop-check-v1-2-556665793fa4@pengutronix.de Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
1 parent 3a20c44 commit 0bee15a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/can/esd/esdacc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ netdev_tx_t acc_start_xmit(struct sk_buff *skb, struct net_device *netdev)
254254
u32 acc_id;
255255
u32 acc_dlc;
256256

257-
if (can_dropped_invalid_skb(netdev, skb))
257+
if (can_dev_dropped_skb(netdev, skb))
258258
return NETDEV_TX_OK;
259259

260260
/* Access core->tx_fifo_tail only once because it may be changed

0 commit comments

Comments
 (0)