Skip to content

Commit 159a740

Browse files
Dan Carpenteralexandrebelloni
authored andcommitted
rtc: atcrtc100: Fix signedness bug in probe()
The "atcrtc_dev->alarm_irq" variable is an unsigned int but it needs to be signed for the error handling to work. Use the "ret" variable instead. Fixes: 7adca70 ("rtc: atcrtc100: Add ATCRTC100 RTC driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/aRxPGBEX8hbY6sjV@stanley.mountain Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent f07640f commit 159a740

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

drivers/rtc/rtc-atcrtc100.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -296,10 +296,12 @@ static int atcrtc_probe(struct platform_device *pdev)
296296
"Failed to initialize RTC: unsupported hardware ID 0x%x\n",
297297
rtc_id);
298298

299-
atcrtc_dev->alarm_irq = platform_get_irq(pdev, 1);
300-
if (atcrtc_dev->alarm_irq < 0)
301-
return dev_err_probe(&pdev->dev, atcrtc_dev->alarm_irq,
299+
ret = platform_get_irq(pdev, 1);
300+
if (ret < 0)
301+
return dev_err_probe(&pdev->dev, ret,
302302
"Failed to get IRQ for alarm\n");
303+
atcrtc_dev->alarm_irq = ret;
304+
303305
ret = devm_request_irq(&pdev->dev,
304306
atcrtc_dev->alarm_irq,
305307
atcrtc_alarm_isr,

0 commit comments

Comments
 (0)