Skip to content

Commit 16bd954

Browse files
TroyMitchell911alexandrebelloni
authored andcommitted
rtc: spacemit: MFD_SPACEMIT_P1 as dependencies
RTC_DRV_SPACEMIT_P1 is a subdevice of P1 and should depend on MFD_SPACEMIT_P1 rather than selecting it directly. Using 'select' does not always respect the parent's dependencies, so 'depends on' is the safer and more correct choice. Additionally, the default value depends on MFD_SPACEMIT_P1 rather than ARCH_SPACEMIT. Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com> Acked-by: Alex Elder <elder@riscstar.com> Link: https://patch.msgid.link/20251118-p1-kconfig-fix-v3-2-8839c5ac5db3@linux.spacemit.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 159a740 commit 16bd954

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/rtc/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -409,8 +409,8 @@ config RTC_DRV_MAX77686
409409
config RTC_DRV_SPACEMIT_P1
410410
tristate "SpacemiT P1 RTC"
411411
depends on ARCH_SPACEMIT || COMPILE_TEST
412-
select MFD_SPACEMIT_P1
413-
default ARCH_SPACEMIT
412+
depends on MFD_SPACEMIT_P1
413+
default MFD_SPACEMIT_P1
414414
help
415415
Enable support for the RTC function in the SpacemiT P1 PMIC.
416416
This driver can also be built as a module, which will be called

0 commit comments

Comments
 (0)