Skip to content

Commit 1759a03

Browse files
robherringlag-linaro
authored andcommitted
dt-bindings: mfd: fsl,mc13xxx: Fix LEDs node schema
The 'leds' node is missing constraints on additional properties. It is mixing 'leds' node and child node properties as well as missing some properties. Add the 'led@' child nodes and the missing properties. Fixes: 1160f9f ("dt-bindings: mfd: fsl,mc13xxx: Convert txt to DT schema") Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Link: https://patch.msgid.link/20251118213541.43812-1-robh@kernel.org Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 384bd58 commit 1759a03

1 file changed

Lines changed: 43 additions & 31 deletions

File tree

Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml

Lines changed: 43 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -93,45 +93,57 @@ properties:
9393

9494
leds:
9595
type: object
96-
$ref: /schemas/leds/common.yaml#
96+
additionalProperties: false
9797

9898
properties:
99-
reg:
100-
description: |
101-
One of
102-
MC13783 LED IDs
103-
0: Main display
104-
1: AUX display
105-
2: Keypad
106-
3: Red 1
107-
4: Green 1
108-
5: Blue 1
109-
6: Red 2
110-
7: Green 2
111-
8: Blue 2
112-
9: Red 3
113-
10: Green 3
114-
11: Blue 3
115-
116-
MC13892 LED IDs
117-
0: Main display
118-
1: AUX display
119-
2: Keypad
120-
3: Red
121-
4: Green
122-
5: Blue
123-
124-
MC34708 LED IDs
125-
0: Charger Red
126-
1: Charger Green
127-
maxItems: 1
99+
'#address-cells':
100+
const: 1
101+
102+
'#size-cells':
103+
const: 0
128104

129105
led-control:
130106
$ref: /schemas/types.yaml#/definitions/uint32-array
131107
description: |
132108
Setting for LED-Control register array length depends on model,
133109
mc13783: 6, mc13892: 4, mc34708: 1
134110
111+
patternProperties:
112+
'^led@[0-9a-b]$':
113+
$ref: /schemas/leds/common.yaml#
114+
unevaluatedProperties: false
115+
116+
properties:
117+
reg:
118+
description: |
119+
One of
120+
MC13783 LED IDs
121+
0: Main display
122+
1: AUX display
123+
2: Keypad
124+
3: Red 1
125+
4: Green 1
126+
5: Blue 1
127+
6: Red 2
128+
7: Green 2
129+
8: Blue 2
130+
9: Red 3
131+
10: Green 3
132+
11: Blue 3
133+
134+
MC13892 LED IDs
135+
0: Main display
136+
1: AUX display
137+
2: Keypad
138+
3: Red
139+
4: Green
140+
5: Blue
141+
142+
MC34708 LED IDs
143+
0: Charger Red
144+
1: Charger Green
145+
maxItems: 1
146+
135147
regulators:
136148
type: object
137149

@@ -262,7 +274,7 @@ examples:
262274
#size-cells = <0>;
263275
led-control = <0x000 0x000 0x0e0 0x000>;
264276
265-
sysled@3 {
277+
led@3 {
266278
reg = <3>;
267279
label = "system:red:live";
268280
linux,default-trigger = "heartbeat";

0 commit comments

Comments
 (0)