Skip to content

Commit 26fe74d

Browse files
chhitzlag-linaro
authored andcommitted
leds: leds-lp50xx: Allow LED 0 to be added to module bank
led_banks contains LED module number(s) that should be grouped into the module bank. led_banks is 0-initialized. By checking the led_banks entries for 0, un-set entries are detected. But a 0-entry also indicates that LED module 0 should be grouped into the module bank. By only iterating over the available entries no check for unused entries is required and LED module 0 can be added to bank. Cc: stable@vger.kernel.org Fixes: 242b811 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver") Signed-off-by: Christian Hitz <christian.hitz@bbv.ch> Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Link: https://patch.msgid.link/20251008123222.1117331-1-christian@klarinett.li Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 7afd533 commit 26fe74d

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

drivers/leds/leds-lp50xx.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -341,17 +341,15 @@ static int lp50xx_brightness_set(struct led_classdev *cdev,
341341
return ret;
342342
}
343343

344-
static int lp50xx_set_banks(struct lp50xx *priv, u32 led_banks[])
344+
static int lp50xx_set_banks(struct lp50xx *priv, u32 led_banks[], int num_leds)
345345
{
346346
u8 led_config_lo, led_config_hi;
347347
u32 bank_enable_mask = 0;
348348
int ret;
349349
int i;
350350

351-
for (i = 0; i < priv->chip_info->max_modules; i++) {
352-
if (led_banks[i])
353-
bank_enable_mask |= (1 << led_banks[i]);
354-
}
351+
for (i = 0; i < num_leds; i++)
352+
bank_enable_mask |= (1 << led_banks[i]);
355353

356354
led_config_lo = bank_enable_mask;
357355
led_config_hi = bank_enable_mask >> 8;
@@ -405,7 +403,7 @@ static int lp50xx_probe_leds(struct fwnode_handle *child, struct lp50xx *priv,
405403
return ret;
406404
}
407405

408-
ret = lp50xx_set_banks(priv, led_banks);
406+
ret = lp50xx_set_banks(priv, led_banks, num_leds);
409407
if (ret) {
410408
dev_err(priv->dev, "Cannot setup banked LEDs\n");
411409
return ret;

0 commit comments

Comments
 (0)