Skip to content

Commit 3e39104

Browse files
ye xingchendtor
authored andcommitted
Input: ims-pcu - use sysfs_emit() instead of scnprintf()
Replace calls to scnprintf() in the methods showing device attributes with sysfs_emit() to simplify the code. Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> Link: https://lore.kernel.org/r/202212011548387254492@zte.com.cn Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 8fbdb8f commit 3e39104

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

drivers/input/misc/ims-pcu.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1050,7 +1050,7 @@ static ssize_t ims_pcu_attribute_show(struct device *dev,
10501050
container_of(dattr, struct ims_pcu_attribute, dattr);
10511051
char *field = (char *)pcu + attr->field_offset;
10521052

1053-
return scnprintf(buf, PAGE_SIZE, "%.*s\n", attr->field_length, field);
1053+
return sysfs_emit(buf, "%.*s\n", attr->field_length, field);
10541054
}
10551055

10561056
static ssize_t ims_pcu_attribute_store(struct device *dev,
@@ -1206,7 +1206,7 @@ ims_pcu_update_firmware_status_show(struct device *dev,
12061206
struct usb_interface *intf = to_usb_interface(dev);
12071207
struct ims_pcu *pcu = usb_get_intfdata(intf);
12081208

1209-
return scnprintf(buf, PAGE_SIZE, "%d\n", pcu->update_firmware_status);
1209+
return sysfs_emit(buf, "%d\n", pcu->update_firmware_status);
12101210
}
12111211

12121212
static DEVICE_ATTR(update_firmware_status, S_IRUGO,
@@ -1309,7 +1309,7 @@ static ssize_t ims_pcu_ofn_reg_data_show(struct device *dev,
13091309
if (error)
13101310
return error;
13111311

1312-
return scnprintf(buf, PAGE_SIZE, "%x\n", data);
1312+
return sysfs_emit(buf, "%x\n", data);
13131313
}
13141314

13151315
static ssize_t ims_pcu_ofn_reg_data_store(struct device *dev,
@@ -1344,7 +1344,7 @@ static ssize_t ims_pcu_ofn_reg_addr_show(struct device *dev,
13441344
int error;
13451345

13461346
mutex_lock(&pcu->cmd_mutex);
1347-
error = scnprintf(buf, PAGE_SIZE, "%x\n", pcu->ofn_reg_addr);
1347+
error = sysfs_emit(buf, "%x\n", pcu->ofn_reg_addr);
13481348
mutex_unlock(&pcu->cmd_mutex);
13491349

13501350
return error;
@@ -1397,7 +1397,7 @@ static ssize_t ims_pcu_ofn_bit_show(struct device *dev,
13971397
if (error)
13981398
return error;
13991399

1400-
return scnprintf(buf, PAGE_SIZE, "%d\n", !!(data & (1 << attr->nr)));
1400+
return sysfs_emit(buf, "%d\n", !!(data & (1 << attr->nr)));
14011401
}
14021402

14031403
static ssize_t ims_pcu_ofn_bit_store(struct device *dev,

0 commit comments

Comments
 (0)