rtc: nct3018y: fix incorrect maximum clock rate handling

masneyb · alexandrebelloni · commit 437c59e4b222 · 2025-08-03T02:57:05.000+02:00
When nct3018y_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: 5adbaed ("rtc: Add NCT3018Y real time clock driver") Signed-off-by: Brian Masney <bmasney@redhat.com> Link: https://lore.kernel.org/r/20250710-rtc-clk-round-rate-v1-3-33140bb2278e@redhat.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
diff --git a/drivers/rtc/rtc-nct3018y.c b/drivers/rtc/rtc-nct3018y.c
@@ -376,7 +376,7 @@ static long nct3018y_clkout_round_rate(struct clk_hw *hw, unsigned long rate,
 		if (clkout_rates[i] <= rate)
 			return clkout_rates[i];
 
-	return 0;
+	return clkout_rates[0];
 }
 
 static int nct3018y_clkout_set_rate(struct clk_hw *hw, unsigned long rate,

Original file line number	Diff line number	Diff line change
`@@ -376,7 +376,7 @@ static long nct3018y_clkout_round_rate(struct clk_hw *hw, unsigned long rate,`
`376`	`376`	`if (clkout_rates[i] <= rate)`
`377`	`377`	`return clkout_rates[i];`
`378`	`378`
`379`		`- return 0;`
	`379`	`+ return clkout_rates[0];`
`380`	`380`	`}`
`381`	`381`
`382`	`382`	`static int nct3018y_clkout_set_rate(struct clk_hw *hw, unsigned long rate,`