Skip to content

Commit 4e21c86

Browse files
Ondrej ZaryDamien Le Moal
authored andcommitted
ata: pata_parport-bpck6: merge ppc6_wr_port16_blk into bpck6_write_block
ppc6_wr_port16_blk is only called by bpck6_write_block. Merge ppc6_wr_port16_blk into bpck6_write_block. Signed-off-by: Ondrej Zary <linux@zary.sk> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
1 parent 3967def commit 4e21c86

2 files changed

Lines changed: 9 additions & 22 deletions

File tree

drivers/ata/pata_parport/bpck6.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,15 @@ static void bpck6_write_regr(struct pi_adapter *pi, int cont, int reg, int val)
3737

3838
static void bpck6_write_block(struct pi_adapter *pi, char *buf, int len)
3939
{
40-
ppc6_wr_port16_blk(pi, ATA_REG_DATA, buf, (u32)len>>1);
40+
ppc6_send_cmd(pi, REG_BLKSIZE | ACCESS_REG | ACCESS_WRITE);
41+
ppc6_wr_data_byte(pi, (u8)len);
42+
ppc6_wr_data_byte(pi, (u8)(len >> 8));
43+
ppc6_wr_data_byte(pi, 0);
44+
45+
ppc6_send_cmd(pi, CMD_PREFIX_SET | PREFIX_IO16 | PREFIX_BLK);
46+
ppc6_send_cmd(pi, ATA_REG_DATA | ACCESS_PORT | ACCESS_WRITE);
47+
ppc6_wr_data_blk(pi, buf, len);
48+
ppc6_send_cmd(pi, CMD_PREFIX_RESET | PREFIX_IO16 | PREFIX_BLK);
4149
}
4250

4351
static void bpck6_read_block(struct pi_adapter *pi, char *buf, int len)

drivers/ata/pata_parport/ppc6lnx.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ static u8 ppc6_rd_data_byte(struct pi_adapter *pi);
7575
static void ppc6_rd_data_blk(struct pi_adapter *pi, u8 *data, long count);
7676
static void ppc6_wait_for_fifo(struct pi_adapter *pi);
7777
static void ppc6_wr_data_blk(struct pi_adapter *pi, u8 *data, long count);
78-
static void ppc6_wr_port16_blk(struct pi_adapter *pi, u8 port, u8 *data, long length);
7978
static void ppc6_wr_extout(struct pi_adapter *pi, u8 regdata);
8079
static int ppc6_open(struct pi_adapter *pi);
8180

@@ -478,26 +477,6 @@ static void ppc6_wr_data_blk(struct pi_adapter *pi, u8 *data, long count)
478477

479478
//***************************************************************************
480479

481-
static void ppc6_wr_port16_blk(struct pi_adapter *pi, u8 port, u8 *data, long length)
482-
{
483-
length = length << 1;
484-
485-
ppc6_send_cmd(pi, REG_BLKSIZE | ACCESS_REG | ACCESS_WRITE);
486-
ppc6_wr_data_byte(pi, (u8)length);
487-
ppc6_wr_data_byte(pi, (u8)(length >> 8));
488-
ppc6_wr_data_byte(pi, 0);
489-
490-
ppc6_send_cmd(pi, CMD_PREFIX_SET | PREFIX_IO16 | PREFIX_BLK);
491-
492-
ppc6_send_cmd(pi, port | ACCESS_PORT | ACCESS_WRITE);
493-
494-
ppc6_wr_data_blk(pi, data, length);
495-
496-
ppc6_send_cmd(pi, CMD_PREFIX_RESET | PREFIX_IO16 | PREFIX_BLK);
497-
}
498-
499-
//***************************************************************************
500-
501480
static void ppc6_wr_extout(struct pi_adapter *pi, u8 regdata)
502481
{
503482
ppc6_send_cmd(pi, REG_VERSION | ACCESS_REG | ACCESS_WRITE);

0 commit comments

Comments
 (0)