Skip to content

Commit 5008c3e

Browse files
Jakub Czapigaprati0100
authored andcommitted
mtd: spi-nor: core: Check read CR support
Some SPI controllers like Intel's one on the PCI bus do not support opcode 35h. This opcode is used to read the Configuration Register on SPI-NOR chips that have 16-bit Status Register configured regardless of the controller support for it. Adding a check call in the setup step allows disabling use of the 35h opcode and falling back to the manual Status Registers management. Before: openat(AT_FDCWD, "/dev/mtd0", O_RDWR) = 4 ioctl(4, MIXER_WRITE(6) or MEMUNLOCK, {start=0, length=0x2000000}) = -1 EOPNOTSUPP After: openat(AT_FDCWD, "/dev/mtd0", O_RDWR) = 4 ioctl(4, MIXER_WRITE(6) or MEMUNLOCK, {start=0, length=0x2000000}) = 0 ioctl(4, MIXER_WRITE(5) or MEMLOCK, {start=0x1800000, length=0x800000}) = 0 Suggested-by: Adeel Arshad <adeel.arshad@intel.com> Signed-off-by: Jakub Czapiga <czapiga@google.com> Reviewed-by: Pratyush Yadav <pratyush@kernel.org> Signed-off-by: Pratyush Yadav <pratyush@kernel.org>
1 parent 7f77c56 commit 5008c3e

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

drivers/mtd/spi-nor/core.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2459,6 +2459,16 @@ spi_nor_spimem_adjust_hwcaps(struct spi_nor *nor, u32 *hwcaps)
24592459
&params->page_programs[ppidx]))
24602460
*hwcaps &= ~BIT(cap);
24612461
}
2462+
2463+
/* Some SPI controllers might not support CR read opcode. */
2464+
if (!(nor->flags & SNOR_F_NO_READ_CR)) {
2465+
struct spi_mem_op op = SPI_NOR_RDCR_OP(nor->bouncebuf);
2466+
2467+
spi_nor_spimem_setup_op(nor, &op, nor->reg_proto);
2468+
2469+
if (spi_nor_spimem_check_op(nor, &op))
2470+
nor->flags |= SNOR_F_NO_READ_CR;
2471+
}
24622472
}
24632473

24642474
/**

0 commit comments

Comments
 (0)