Skip to content

Commit 72e5c0d

Browse files
jgross1groeck
authored andcommitted
hwmon/w83781d: Drop REALLY_SLOW_IO setting
In w83781d_isa_found() there is REALLY_SLOW_IO defined around some port accesses, probably in order to wait between multiple accesses. Unfortunately this isn't making any difference compared to not having this define since more than a decade, as REALLY_SLOW_IO needs to be defined while "#include <asm/io.h>" is called to have an effect. As there seem not to be any outstanding issues in spite of this having no effect, just drop the "#define" and add a remark to the related comment. Signed-off-by: Juergen Gross <jgross@suse.com> Link: https://lore.kernel.org/r/20251126162018.5676-4-jgross@suse.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 8ac2a19 commit 72e5c0d

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/hwmon/w83781d.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1850,10 +1850,12 @@ w83781d_isa_found(unsigned short address)
18501850
}
18511851
}
18521852

1853-
#define REALLY_SLOW_IO
18541853
/*
18551854
* We need the timeouts for at least some W83781D-like
18561855
* chips. But only if we read 'undefined' registers.
1856+
* There used to be a "#define REALLY_SLOW_IO" to enforce that, but
1857+
* this has been without any effect since more than a decade, so it
1858+
* has been dropped.
18571859
*/
18581860
val = inb_p(address + 1);
18591861
if (inb_p(address + 2) != val
@@ -1862,7 +1864,6 @@ w83781d_isa_found(unsigned short address)
18621864
pr_debug("Detection failed at step %d\n", 1);
18631865
goto release;
18641866
}
1865-
#undef REALLY_SLOW_IO
18661867

18671868
/*
18681869
* We should be able to change the 7 LSB of the address port. The

0 commit comments

Comments
 (0)