Skip to content

Commit 973f80d

Browse files
matttbekuba-moo
authored andcommitted
selftests: mptcp: join: mark implicit tests as skipped if not supported
The call to 'continue_if' was missing: it properly marks a subtest as 'skipped' if the attached condition is not valid. Without that, the test is wrongly marked as passed on older kernels. Fixes: 36c4127 ("selftests: mptcp: join: skip implicit tests if not supported") Cc: stable@vger.kernel.org Reviewed-by: Geliang Tang <geliang@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Link: https://patch.msgid.link/20251020-net-mptcp-c-flag-late-add-addr-v1-3-8207030cb0e8@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent d68460b commit 973f80d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3939,7 +3939,7 @@ endpoint_tests()
39393939
# subflow_rebuild_header is needed to support the implicit flag
39403940
# userspace pm type prevents add_addr
39413941
if reset "implicit EP" &&
3942-
mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
3942+
continue_if mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
39433943
pm_nl_set_limits $ns1 2 2
39443944
pm_nl_set_limits $ns2 2 2
39453945
pm_nl_add_endpoint $ns1 10.0.2.1 flags signal
@@ -3964,7 +3964,7 @@ endpoint_tests()
39643964
fi
39653965

39663966
if reset_with_tcp_filter "delete and re-add" ns2 10.0.3.2 REJECT OUTPUT &&
3967-
mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
3967+
continue_if mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
39683968
start_events
39693969
pm_nl_set_limits $ns1 0 3
39703970
pm_nl_set_limits $ns2 0 3

0 commit comments

Comments
 (0)