Skip to content

Commit 9f5f69d

Browse files
DispatchCodeaxboe
authored andcommitted
io_uring: replace use of system_unbound_wq with system_dfl_wq
Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. system_unbound_wq should be the default workqueue so as not to enforce locality constraints for random work whenever it's not required. Adding system_dfl_wq to encourage its use when unbound work should be used. queue_work() / queue_delayed_work() / mod_delayed_work() will now use the new unbound wq: whether the user still use the old wq a warn will be printed along with a wq redirect to the new one. The old system_unbound_wq will be kept for a few release cycles. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 8577441 commit 9f5f69d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

io_uring/io_uring.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3103,7 +3103,7 @@ static __cold void io_ring_ctx_wait_and_kill(struct io_ring_ctx *ctx)
31033103

31043104
INIT_WORK(&ctx->exit_work, io_ring_exit_work);
31053105
/*
3106-
* Use system_unbound_wq to avoid spawning tons of event kworkers
3106+
* Use system_dfl_wq to avoid spawning tons of event kworkers
31073107
* if we're exiting a ton of rings at the same time. It just adds
31083108
* noise and overhead, there's no discernable change in runtime
31093109
* over using system_percpu_wq.

0 commit comments

Comments
 (0)