Skip to content

Commit c8f796f

Browse files
committed
fbdev/sisfb: Unexport symbols
Fix the compile-time warning drivers/video/fbdev/sis/sis_main.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing The affected symbols are not used outside of their module. Some of the symbols are not used anywhere, so remove the functions entirely. Also remove the related, but unused, define SISFB_HAVE_MALLOC_NEW. v2: - remove unused functions (Helge) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Helge Deller <deller@gmx.de> Fixes: a934a57 ("scripts/misc-check: check missing #include <linux/export.h> when W=1") Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Nathan Chancellor <nathan@kernel.org> Link: https://lore.kernel.org/r/20250612081738.197826-13-tzimmermann@suse.de
1 parent 9bf9f98 commit c8f796f

3 files changed

Lines changed: 0 additions & 33 deletions

File tree

drivers/video/fbdev/sis/sis.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -673,9 +673,7 @@ unsigned int sisfb_read_mio_pci_word(struct SiS_Private *SiS_Pr, int reg);
673673

674674
/* SiS-specific exported functions */
675675
void sis_malloc(struct sis_memreq *req);
676-
void sis_malloc_new(struct pci_dev *pdev, struct sis_memreq *req);
677676
void sis_free(u32 base);
678-
void sis_free_new(struct pci_dev *pdev, u32 base);
679677

680678
/* Routines from init.c/init301.c */
681679
extern unsigned short SiS_GetModeID_LCD(int VGAEngine, unsigned int VBFlags, int HDisplay,

drivers/video/fbdev/sis/sis_main.c

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -3421,14 +3421,6 @@ sis_malloc(struct sis_memreq *req)
34213421
req->offset = req->size = 0;
34223422
}
34233423

3424-
void
3425-
sis_malloc_new(struct pci_dev *pdev, struct sis_memreq *req)
3426-
{
3427-
struct sis_video_info *ivideo = pci_get_drvdata(pdev);
3428-
3429-
sis_int_malloc(ivideo, req);
3430-
}
3431-
34323424
/* sis_free: u32 because "base" is offset inside video ram, can never be >4GB */
34333425

34343426
static void
@@ -3455,14 +3447,6 @@ sis_free(u32 base)
34553447
sis_int_free(ivideo, base);
34563448
}
34573449

3458-
void
3459-
sis_free_new(struct pci_dev *pdev, u32 base)
3460-
{
3461-
struct sis_video_info *ivideo = pci_get_drvdata(pdev);
3462-
3463-
sis_int_free(ivideo, base);
3464-
}
3465-
34663450
/* --------------------- SetMode routines ------------------------- */
34673451

34683452
static void
@@ -6832,12 +6816,3 @@ MODULE_PARM_DESC(videoram,
68326816
#endif
68336817

68346818
#endif /* /MODULE */
6835-
6836-
/* _GPL only for new symbols. */
6837-
EXPORT_SYMBOL(sis_malloc);
6838-
EXPORT_SYMBOL(sis_free);
6839-
EXPORT_SYMBOL_GPL(sis_malloc_new);
6840-
EXPORT_SYMBOL_GPL(sis_free_new);
6841-
6842-
6843-

include/video/sisfb.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,4 @@
1515
#define SIS_300_VGA 1
1616
#define SIS_315_VGA 2
1717

18-
#define SISFB_HAVE_MALLOC_NEW
19-
extern void sis_malloc(struct sis_memreq *req);
20-
extern void sis_malloc_new(struct pci_dev *pdev, struct sis_memreq *req);
21-
22-
extern void sis_free(u32 base);
23-
extern void sis_free_new(struct pci_dev *pdev, u32 base);
2418
#endif

0 commit comments

Comments
 (0)