Skip to content

Commit d02f20a

Browse files
actia-martin-larssonBartosz Golaszewski
authored andcommitted
gpio: pca953x: mask interrupts in irq shutdown
In the existing implementation irq_shutdown does not mask the interrupts in hardware. This can cause spurious interrupts from the IO expander. Add masking to irq_shutdown to prevent spurious interrupts. Cc: stable@vger.kernel.org Signed-off-by: Martin Larsson <martin.larsson@actia.se> Reviewed-by: Linus Walleij <linusw@kernel.org> Link: https://lore.kernel.org/r/20260121125631.2758346-1-martin.larsson@actia.se Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
1 parent 53ad4a9 commit d02f20a

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/gpio/gpio-pca953x.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -914,6 +914,8 @@ static void pca953x_irq_shutdown(struct irq_data *d)
914914
clear_bit(hwirq, chip->irq_trig_fall);
915915
clear_bit(hwirq, chip->irq_trig_level_low);
916916
clear_bit(hwirq, chip->irq_trig_level_high);
917+
918+
pca953x_irq_mask(d);
917919
}
918920

919921
static void pca953x_irq_print_chip(struct irq_data *data, struct seq_file *p)

0 commit comments

Comments
 (0)