Skip to content

Commit d216b69

Browse files
author
Trond Myklebust
committed
Revert "nfs: clear SB_RDONLY before getting superblock"
This reverts commit 8cd9b78. Silently ignoring the "ro" and "rw" mount options causes user confusion, and regressions. Reported-by: Alkis Georgopoulos<alkisg@gmail.com> Cc: Li Lingfeng <lilingfeng3@huawei.com> Fixes: 8cd9b78 ("nfs: clear SB_RDONLY before getting superblock") Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent 400fa37 commit d216b69

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

fs/nfs/super.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1308,17 +1308,8 @@ int nfs_get_tree_common(struct fs_context *fc)
13081308
if (IS_ERR(server))
13091309
return PTR_ERR(server);
13101310

1311-
/*
1312-
* When NFS_MOUNT_UNSHARED is not set, NFS forces the sharing of a
1313-
* superblock among each filesystem that mounts sub-directories
1314-
* belonging to a single exported root path.
1315-
* To prevent interference between different filesystems, the
1316-
* SB_RDONLY flag should be removed from the superblock.
1317-
*/
13181311
if (server->flags & NFS_MOUNT_UNSHARED)
13191312
compare_super = NULL;
1320-
else
1321-
fc->sb_flags &= ~SB_RDONLY;
13221313

13231314
/* -o noac implies -o sync */
13241315
if (server->flags & NFS_MOUNT_NOAC)

0 commit comments

Comments
 (0)