Skip to content

test(core): stop lifecycle restart test from hanging the suite #10640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yuexia5 wants to merge 1 commit into from
Closed

test(core): stop lifecycle restart test from hanging the suite #10640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tests/unit/test_core_lifecycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,12 @@ async def test_restart_terminates_managers_and_starts_thread(

lifecycle.astrbot_updater = MagicMock()

with patch("astrbot.core.core_lifecycle.threading.Thread") as mock_thread:
# Patch the module reference used by the lifecycle code instead of the
# global ``threading.Thread``. ``restart()`` awaits
# ``asyncio.to_thread(...)``, whose ThreadPoolExecutor spawns its worker
# with ``threading.Thread``; a process-wide mock would make that worker
# a no-op MagicMock and hang the awaiting future forever.
with patch("astrbot.core.core_lifecycle.threading") as mock_threading:
await lifecycle.restart()

# Verify managers were terminated
Expand All @@ -904,8 +909,8 @@ async def test_restart_terminates_managers_and_starts_thread(
lifecycle.kb_manager.terminate.assert_awaited_once()

# Verify thread was started
mock_thread.assert_called_once()
mock_thread.return_value.start.assert_called_once()
mock_threading.Thread.assert_called_once()
mock_threading.Thread.return_value.start.assert_called_once()


class TestAstrBotCoreLifecycleLoadPipelineScheduler:
Expand Down