Skip to content

fix: prefer file-reading tools when loading skills - #10789

Merged
Soulter merged 2 commits into
masterfrom
codex/fix-skill-file-reading
Oct 26, 2026
Merged

Soulter merged 2 commits into
masterfrom
codex/fix-skill-file-reading

Conversation

@Soulter

@Soulter Soulter commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Prefer an available, permitted file-reading tool when loading SKILL.md, with shell as a fallback. This removes the mandatory shell requirement that blocks Local members without execution permission.

Validation: ruff format ., ruff check ., and 37 passing tests in tests/test_skill_metadata_enrichment.py.

Fixes #10777

Summary by Sourcery

Bug Fixes:

  • Allow skill instructions to be loaded with permitted file-reading tools before falling back to shell commands, removing the mandatory shell-execution requirement.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@Soulter
Soulter merged commit d5a01eb into master Oct 26, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Skill 提示词强制使用 Shell 读取,Local 普通成员无法读取 SKILL.md

1 participant