Repository navigation
CLI: Shrink the concurrent server-files install test so it fits Windows CI's time limit - #5499
Merged
Merged
Conversation
chubes4
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude (via the Pi coding agent in a Roadie session) found the Windows timeouts in CI logs and wrote the change. I reviewed it.
Proposed Changes
The test from #5314 runs eight concurrent installs of a 400-file WordPress copy. It takes about 1 s on macOS but sometimes exceeds Vitest's default 5 s on the Windows Unit Tests agent, which failed Windows Unit Tests on #5494 (build 24210) and #5495 (build 24211) with
Test timed out in 5000ms. Its trunk runs passed, so it is intermittent.The size adds no detection. Run 5 times each on macOS against #5314's fix and against the code before it:
Before the fix, the failing check is the one this test exists for:
latestshowsversion.phpbefore all its files are there. This shrinks the test to two installs of 50 files, which keeps the concurrent and interrupted-copy paths at about 1/30 of the file work.Testing Instructions
npx vitest run --project cli apps/cli/lib/dependency-management/tests/setup-server-files.test.tspasses. Withapps/cli/lib/dependency-management/setup.tsfrom before CLI: Install the bundled WordPress into server-files atomically so concurrent commands never copy a partial install #5314, it fails.Pre-merge Checklist