Repository navigation
Conversation
robertbpugh
left a comment
There was a problem hiding this comment.
Looks good overall, and the new sentence about tags being shared as hashtags reads well. I had Claude review it, and there's one title I think is worth changing, plus a small wording idea. Both are inline.
robertbpugh
left a comment
There was a problem hiding this comment.
Thanks for the changes, the tag sentence reads well now. I had Claude look at the new version, and there's one thing in the description worth updating before merge, plus an idea for the format box. Both are inline.
…-hint # Conflicts: # package-lock.json # package.json
robertbpugh
left a comment
There was a problem hiding this comment.
Thanks for adding the format sentence, it reads well after core's text. I had Claude look at the latest version, and there are two small things worth a look before merge. Both are inline.
| * @type {string} | ||
| */ | ||
| const CORE_TAGS_TEXT = | ||
| '%s help users and search engines navigate your site and find your content. Add a few keywords to describe your post.'; |
There was a problem hiding this comment.
On WordPress 6.5 to 6.8, which the plugin still supports, core's tag box says "Tags help users and search engines navigate your site..." with no %s. The %s version only came in after 6.8, so people on those versions never see the hashtag sentence. Could you match the old text too? It isn't passed through sprintf, so it wouldn't need the %% escaping.
| Significance: minor | ||
| Type: added | ||
|
|
||
| Before publishing a post without tags, the tag suggestion now explains that tags are shared as hashtags, which help people on the Fediverse find your post. |
There was a problem hiding this comment.
The changelog only mentions the tag sentence, but people who update will also see the new format sentence and the reworded format suggestion. Maybe "Before publishing, the tag and post format suggestions now explain what tags and formats do on the Fediverse." so the entry covers both.
Proposed changes:
i18n.gettext_defaultfilter and matches the English source, so it works in every language and does nothing if core changes the string.Core only shows its tag suggestion when the site already has tags, so a site without any tags gets no hint. I think that is fine for now. I first opened the tag panel by itself, but that was hacky, so I filed WordPress/gutenberg#86688 and WordPress/gutenberg#86691 on Gutenberg and may come back to it in a follow-up.
/cc @allilevine @robertbpugh
Other information:
Testing instructions:
Screenshots:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Before publishing a post without tags, the tag suggestion now explains that tags are shared as hashtags, which help people on the Fediverse find your post.