Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4064
Proposed changes:
Mention::filter_activity_object()linked mentions insummary, but not insummaryMap, which is built earlier from the plain summary. So the two differed, and GoToSocial showed the mention as@user <https://…>.Mention,HashtagandLinknow also link every value insummaryMapandcontentMap. This also covers translations that plugins add throughactivitypub_transform_set_summary_mapandactivitypub_transform_set_content_map.HashtagandLinkkeep theis_actor()check forsummaryMap, the same as forsummary, so the summary of a post stays plain text (Improve summary generation #2063).Other information:
Testing instructions:
@searls@mastodon.social nails it….?activitypub(or fetch it withAccept: application/activity+json).summaryand the value insummaryMapare the same, both with the linked mention.contentMapmatchescontent.Changelog entry
The entry is in
.github/changelog/fix-mention-summary-map.