fix: tolerate unavailable redis in ci3 logging#24572
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the nightly debug build wrapper failure from https://github.com/AztecProtocol/aztec-claude/actions/runs/28845951015.
Root cause:
redis_setexzpiped input throughgzip | redis_cli -x ...even whenCI_REDIS_AVAILABLE=0. In that moderedis_clireturned without reading stdin, sogziphit SIGPIPE and the strictset -euo pipefailpath aborted beforebootstrap_ec2could launch the build.Changes:
redis_setexz.redis_cli -xdrain stdin as well, covering the directcat ... | redis_cli -x SETEX ...path.ci3/tests/redis_testfor the no-Redis pipefail behavior.Verification
ci3/tests/redis_testenv CI=1 CI_REDIS_AVAILABLE=0 bash -c 'set -euo pipefail; NO_CD=1 source ci3/source; echo "CI booting..." | redis_setexz test-key 1'bash -n ci3/source_redis ci3/tests/redis_testgit diff --check./ci3/bootstrap.shalso ran the new test successfully, then failed in existingci3/tests/signal_testbecause Docker is unavailable in this container and that test's EXIT cleanup trap returns nonzero after its skip path.Created by claudebox · group:
slackbot