feat: merge-train/spartan-v5#24596
Merged
Merged
Conversation
…24593) `CheckpointSubTreeOrchestrator.addTxs` logs `Provided no txs to addTxs.` at **warn** level, but this path is expected control flow, not an anomaly: `checkpoint-prover.ts` calls `this.subTree.addTxs(processed)` unconditionally for every block in the checkpoint, so every empty block hits this early return (the empty block is then finalized via `setBlockCompleted`). On low-traffic networks this fires constantly — ~100 times in 4h on staging-internal — polluting warn-level log reviews with noise. Demote it to `verbose`. No behavior change; no tests assert on this message. Replaces #24591 and #24592 (closed), per request to land this as a single PR via the spartan-v5 merge train. Spotted during a staging-internal log review requested by @spalladino in Slack. --- *Created by [claudebox](https://claudebox.work/v2/sessions/ac050bae673edac4) · group: `slackbot`*
Adds a new `THREAT_MODEL.md` doc. This document describes the threat model of the Aztec L2 network: how transactions flow from users into the proven chain, what each participant can and cannot do, and the properties the implementation must uphold. It is intended as a guideline for the security of the node implementation (`yarn-project`) and its interaction with the L1 rollup contracts (`l1-contracts`). **In scope**: transaction dissemination and the mempool, the p2p layer, block and checkpoint production, committee attestation, L1 checkpoint submission and sync, epoch proving, slashing, and the escape hatch. **Out of scope**: client-side private execution and proving (PXE, wallets), hardening of a node's public RPC interface, the cryptographic soundness of the proving system itself (treated as an assumption below), and L1 governance internals.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore(prover-client): demote empty addTxs log from warn to verbose (#24593)
docs: threat model for node (#24465)
END_COMMIT_OVERRIDE