feat: rolling-hash buckets in the Inbox alongside frontier trees (A-1377)#24617
Draft
AztecBot wants to merge 2 commits into
Draft
feat: rolling-hash buckets in the Inbox alongside frontier trees (A-1377)#24617AztecBot wants to merge 2 commits into
AztecBot wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AZIP-22 Fast Inbox, FI-07. First L1 PR of the series; a follow-up stacks the
propose-side streaming validation on top of this branch.The first commit copies the small L1 diffs already carried by the circuits stack (#24587 → #24600 → #24603 → #24612) — the header's
inboxRollingHashfield, the two epoch-proof public inputs, and the regenerated checkpoint fixtures — so this branch and that stack merge cleanly intomerge-train/spartan-v6in either order.What
sendL2Messageadditionally maintains the consensus rolling hash — the truncated-per-link sha256 chain the circuits recompute (h' = sha256ToField(h || leaf), genesis zero; newHash.accumulateInboxRollingHash) — and snapshots it into a fixed-size ring of buckets. Frontier trees,LAG, the legacyconsume()flow, and the legacybytes16keccak rolling hash are untouched (the legacy hash now carries a TODO to remove it at cleanup); buckets are completely inert for the legacy flow.Per the pinned design decisions:
{rollingHash | totalMsgCount: uint64, timestamp: uint64, msgCount: uint32}packs into two slots;totalMsgCountis the Inbox-wide cumulative count (what the censorship cap-escape check reads),timestampis the bucket's opening L1 block timestamp (recency checks are done in seconds),msgCountsits in slot 2's spare bits so the per-bucket cap costs no extra storage access.seq % BUCKET_RING_SIZE), 1024 entries in production, sized as an immutable constructor parameter.getBucket(seq)reverts withInbox__BucketOutOfWindowoutside the live window (seq <= current < seq + ringSize, same idiom as the Rollup's roundabout). Overwrite protection for unconsumed buckets is deliberately not enforced yet (happy path assumes the ring never wraps into live data).MAX_MSGS_PER_BUCKET = 256, the post-flip per-L2-block insertion cap) rolls over into the next bucket with the same timestamp. New buckets inherit the rolling hash and cumulative count, so the chain is continuous across buckets.{0, 0, deployTime}and never absorbs (even for a message sent in the deployment block), so a checkpoint consuming nothing against an empty Inbox can always reference a bucket matching its parent's chain position — no special case atpropose.MessageSentgainsbytes32 inboxRollingHashanduint256 bucketSeqafter the legacy args.Archiver / TS
The generated
InboxAbipicks up the new event signature at build time;MessageSentArgsand the decode inethereum/src/contracts/inbox.tscarry the two new fields, and the archiver keeps relying only on the legacy args for now (InboxMessageunchanged). The archiver test fake fills the new fields with placeholders. Nothing on this branch consumes the new values yet — the node-side cross-check of its TS rolling hash against L1-emitted values comes with the archiver bucket-sync work.Testing
InboxBuckets.t.solcovers the roadmap done-when: accumulation within a block, snapshot freezing at block boundaries with chain continuity into the next bucket, 256-cap rollover within one block, ring wraparound + out-of-window reverts on a small ring, the genesis bucket (including a first message in the deploy block), and event contents.chain(0,[11]),chain(0,[11,22,33]),chain(0,[1..=256]),chain(0x2a,[7]),chain(0x2a,[7,8])) are asserted against the L1 implementation, so L1, TS, and the circuits provably compute the same chain.forge testsuite: 878 passed, 0 failed (7 pre-existing skips). ExistingMessageSentexpectations in Inbox/TokenPortal/FeeJuicePortal tests updated for the extended event.yarn-projectis not buildable in this workspace (no noir toolchain), so its typecheck runs in CI.Created by claudebox · group:
slackbot