Skip to content

fix(sol): use pinned compiler for bb sol build#24624

Merged
fcarreiro merged 1 commit into
merge-train/spartanfrom
cb/fix-spartan-solc-download
Jul 9, 2026
Merged

fix(sol): use pinned compiler for bb sol build#24624
fcarreiro merged 1 commit into
merge-train/spartanfrom
cb/fix-spartan-solc-download

Conversation

@AztecBot

@AztecBot AztecBot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Backport the Foundry config fix from #24620 to merge-train/spartan.
  • Move the barretenberg/sol solc setting into [profile.default] so Foundry actually uses ../../l1-contracts/solc-0.8.30.

Why

#24620 fixed the v5 train after bb-sol ignored the intended pinned compiler and fell back to Foundry's SVM download path. merge-train/spartan had the same TOML scoping issue.

Verification

  • forge config --json in barretenberg/sol reports "solc": "../../l1-contracts/solc-0.8.30".
  • make bb-sol passed.

Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jul 9, 2026
@fcarreiro fcarreiro marked this pull request as ready for review July 9, 2026 08:32
@fcarreiro fcarreiro enabled auto-merge (squash) July 9, 2026 08:32
@AztecBot

AztecBot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/8db01bd7093a8571�8db01bd7093a85718;;�): yarn-project/kv-store/scripts/run_test.sh src/sqlite-opfs/internal/ordered-binary-browser.test.ts (1s) (code: 0)

@fcarreiro fcarreiro merged commit e0c10a1 into merge-train/spartan Jul 9, 2026
39 of 47 checks passed
@fcarreiro fcarreiro deleted the cb/fix-spartan-solc-download branch July 9, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants