feat: tx effects tree - #25332
Open
IlyasRidhuan wants to merge 2 commits into
Open
Conversation
Adds a per-block commitment to tx effects: the tx base circuit computes a leaf binding the tx hash to a structured hash of the tx's effects, tx merges accumulate leaves pairwise up the (unbalanced, greedily filled) rollup tree, and the block root writes the root into the new BlockHeader.tx_effects_tree_root field. The tree shape is a pure function of the tx count, so a header holder can verify "tx X was included and produced exactly effects E" with a single membership proof instead of replaying the checkpoint's sponge blob. The tx effect hash is structured: each variable-length field is hashed on its own over its slice of the existing blob encoding (shared slice builders extracted in tx_blob_data.nr), so proving one field only needs that field's preimage. Four new domain separators keep field hashes, effect hashes, leaves and internal nodes mutually incompatible. The header change shifts the genesis constants and bumps the oracle interface major version (30 -> 31) and the TXE oracle major version (8 -> 9); the C++ world state adds the zero field to the initial block header hash.
IlyasRidhuan
requested review from
iAmMichaelConnor
and removed request for
LeilaWang and
nventuro
August 27, 2026 17:00
Rollup Prover.toml sample inputs regenerated from a mock orchestrator run and the private kernel reset config from the gate-count refresh; both pick up the new header/tx-rollup field. The private kernel and tx base sample inputs are carried from the pre-rebase generation: they still execute, except private-kernel-init-simulated, which embeds protocol-contract storage reads and needs a regeneration that requires re-pinning the standard contracts. Drops the pinned mock protocol-circuit build so the circuits rebuild from source with the new header layout.
IlyasRidhuan
force-pushed
the
ir/tx-effects-tree
branch
from
August 27, 2026 18:08
8819588 to
3065ab5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a tx effects unbalanced tree to the rollup, enabling more efficient proofs of tx effects.
Today, proving "tx X was included in this block and produced effects E" means replaying the whole checkpoint's blob sponge. With this root, it takes a single membership proof against one header field.
Summary
Structured leaf hash
Wiring
Blob encoding refactor.
tx_blob_data.nrso the same formats are used for the blob encoding and the new per-field hashesBreaking / versioning
tx_effects_tree_root)