fix(labs): record the labs submodule in barretenberg/sol/foundry.lock and keep both locks in step with bumps - #25347
Open
ludamad wants to merge 6 commits into
Open
fix(labs): record the labs submodule in barretenberg/sol/foundry.lock and keep both locks in step with bumps#25347ludamad wants to merge 6 commits into
ludamad wants to merge 6 commits into
Conversation
… and keep both locks in step with bumps forge records every submodule of the repository in each foundry.lock and rewrites a rev that does not match the gitlink, which CI reports as a change to a rebuild pattern. l1-contracts/foundry.lock got its labs entry with the submodule; barretenberg/sol/foundry.lock did not, and bb-sol-tests now fails whenever it actually runs (the private release run hit it; public runs had been served from the test cache). Adds the entry, and makes `labs-patches/bootstrap.sh bump` rewrite the labs rev in every foundry.lock that records it, so a pin move cannot leave a lock behind. Lifecycle test covers the sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forge records every git submodule of the repository in each
foundry.lockand rewrites a rev that does not match the gitlink; underCI=1that is "changes to rebuild patterns".l1-contracts/foundry.lockhas had a../labsentry since #25306;barretenberg/sol/foundry.locknever got one, sobb-sol-testsfails whenever it really runs — the private release run on aztec-packages-private#714 hit it; public runs had been served from the test cache."../../labs"at the current pin (1f14e9a6) tobarretenberg/sol/foundry.lock(no trailing newline, as forge writes it).labs-patches/bootstrap.sh bumpnow rewrites the labs rev in every trackedfoundry.lockthat records it and stages them, so a pin move cannot leave a lock behind (chore(labs): bump the submodule to aztec-node main and carry the work that never reached it #25333 updated the l1-contracts one by hand). Lifecycle test covers it.