refactor(pxe): migrate FactStore to BaseStagingStore (backport of aztec-labs-eng/aztec-node#98) - #25368
Open
nventuro wants to merge 1 commit into
Conversation
* refactor(pxe): migrate FactStore to BaseStagingStore * refactor(pxe): split staging-store change set ops by DB access (cherry picked from commit 4a7a2e233528f717e6c22e894526831367d80be3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of aztec-labs-eng/aztec-node#98 to the v5 line: a
git cherry-pick -xof its squash commit onaztec-node/main,4a7a2e233528f717e6c22e894526831367d80be3. The change itself was described and reviewed there; this PR is only about the port being faithful, so please review it as such.Validating the backport
Fetch the source repo once:
git remote add node https://github.com/aztec-labs-eng/aztec-node && git fetch node main.Compare the upstream patch with this PR's patch (
range-diffcompares patches, so unrelated histories are fine):Expected: the
(cherry picked from commit …)trailer, and exactly one patch-level difference, inyarn-project/pxe/src/storage/fact_store/fact_store.ts:Same removal on both sides; the package scope differs because upstream renamed its packages from
@aztec/*to@aztec-labs/*(chore: publish labs packages under the @aztec-labs npm scope aztec-labs-eng/aztec-node#93) before this PR merged there, and this repo keeps@aztec/*. For the same reason the surrounding import lines show up as context-only differences (a single-or+followed by a space). No other file differs.Build and run the unit suites at this commit (from
yarn-project/):yarn workspace @aztec/pxe build && yarn workspace @aztec/txe build && yarn workspace @aztec/pxe test && yarn workspace @aztec/txe test. The upstream PR's own tests are part of these suites, so passing them is the behavioral check; CI on this PR runs them as well.Confirm the upstream scope rename leaked nothing into this repo:
git grep -c @aztec-labs -- yarn-projecton this PR's head must return no matches.Stack
Stacked on the backport of aztec-labs-eng/aztec-node#100 (base branch
nico/port-node-100-coordinator-failure-paths); to be rebased ontomerge-train/fairies-v5once that one merges. Order: #20 → #35 → #40 → #47 → #94 → #100 → #98 (aztec-node numbers).