Fix ownership check#188
Merged
Merged
Conversation
RichardChen820
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an issue in
verifyExistingTargetObjectin utils.go:202, which authorized adoption/overwrite of a pre-existing target ConfigMap/Secret using onlyownerRef.Name == providerName. This let a foreign owner reference (e.g.Deployment/frontendorCertificate/payments-cert) authorize a same-named AzureAppConfigurationProvider to overwrite the Secret's data.Fix — the ownership check now requires the owner reference to fully identify the same provider:
APIVersionmatchesazconfig.io/v1(acpv1.GroupVersion.String())KindmatchesAzureAppConfigurationProvider(the existing ProviderName constant)Namematches the provider nameUIDmatches the provider's UID (also rejects a stale/recreated provider with the same name)