Bump @typescript-eslint/eslint-plugin from 8.68.0 to 8.69.0 - #2772
Conversation
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 8.68.0 to 8.69.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.69.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.69.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:
Impact analysis
Build/Conflict Issues
Tests
Run the Suite
Changelog
Comments
Self-Rate
Summary
|
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Addressed in |
| - Updated lockfile-resolved `lint-staged` from 17.3.0 to 17.4.1 to pick up `picomatch` 4.0.7 and `tinyexec` 1.3.0; moved `.lintstagedrc` flat-format coverage into `tests/packageScripts.test.ts`. | ||
| - Bumped `morgan` from `^1.11.0` to `^1.12.0` (lockfile resolved to 1.12.0) to remediate CVE-2026-15603 (log forging via Unicode line separators in access log tokens); no Azurite source code changes were required. | ||
| - Updated lockfile-resolved `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` versions from 8.67.0 to 8.68.0 for bug fixes and rule updates. | ||
| - Updated lockfile-resolved `@typescript-eslint/eslint-plugin` from 8.68.0 to 8.69.0 for rule fixes; added ESLint recommended-rule integration coverage with no application code changes. |
There was a problem hiding this comment.
Copilot , could you please merge both of these enteries
There was a problem hiding this comment.
Addressed in 986657f: the adjacent TypeScript ESLint changelog entries are merged into one entry that includes both @typescript-eslint/eslint-plugin and @typescript-eslint/parser, and notes the ESLint integration coverage.
There was a problem hiding this comment.
🟡 Changes recommended
The new ESLint integration test is currently brittle due to potential extra lint messages (ordering/severity), and the changelog entry should reflect that @typescript-eslint/parser is also updated in the lockfile.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 2
- Review effort level: Lite
| - Updated lockfile-resolved `lint-staged` from 17.3.0 to 17.4.1 to pick up `picomatch` 4.0.7 and `tinyexec` 1.3.0; moved `.lintstagedrc` flat-format coverage into `tests/packageScripts.test.ts`. | ||
| - Bumped `morgan` from `^1.11.0` to `^1.12.0` (lockfile resolved to 1.12.0) to remediate CVE-2026-15603 (log forging via Unicode line separators in access log tokens); no Azurite source code changes were required. | ||
| - Updated lockfile-resolved `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` versions from 8.67.0 to 8.68.0 for bug fixes and rule updates. | ||
| - Updated lockfile-resolved `@typescript-eslint/eslint-plugin` from 8.68.0 to 8.69.0 for rule fixes; added ESLint recommended-rule integration coverage with no application code changes. |
There was a problem hiding this comment.
🟡 Changes recommended
The changelog entry’s “from” version does not match the actual lockfile bump, and the new lint test assertion is fragile without also constraining/locating the expected message reliably.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
tests/eslintConfig.test.ts:37
- The new lint test asserts a specific rule ID using result.messages[0] but doesn't assert warningCount==0; if any warnings are reported (or message ordering changes), messages[0] may not be the expected rule and the test will fail for reasons unrelated to whether the recommended rule is enabled.
assert.strictEqual(result.errorCount, 1, JSON.stringify(result.messages));
assert.strictEqual(
result.messages[0].ruleId,
"@typescript-eslint/no-empty-object-type"
);
- Files reviewed: 2/3 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The added ESLint fixture is likely to trip no-meaningless-void-operator behavior introduced in 8.69.0 and the changelog “from” version is inconsistent with the actual bump described by the PR.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
ChangeLog.md:12
- This changelog entry says the lockfile-resolved versions were updated from 8.67.0 to 8.69.0, but this PR (and its title/lockfile diff) only bumps the resolved versions from 8.68.0 to 8.69.0. Updating the "from" version will keep the entry accurate for this specific change.
- Updated lockfile-resolved `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` versions from 8.67.0 through 8.69.0 for bug fixes and rule updates; added ESLint recommended-rule integration coverage with no application code changes.
- Files reviewed: 2/3 changed files
- Comments generated: 1
- Review effort level: Lite
| const eslint = new ESLint({ cwd: path.resolve(__dirname, "..") }); | ||
| const [result] = await eslint.lintText( | ||
| 'interface Empty {}\nconst value: Empty = {};\nvoid value;\n', | ||
| { filePath: "src/lintFixture.ts" } | ||
| ); |
There was a problem hiding this comment.
🟢 Approval recommended
The change is a low-risk dependency patch update with an added integration test, and only a minor changelog phrasing nit was identified.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
ChangeLog.md:12
- ChangeLog entries in this file consistently use the phrasing "from X to Y"; using "through" here is inconsistent and reads a bit ambiguously.
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
Bumps @typescript-eslint/eslint-plugin from 8.68.0 to 8.69.0.
Release notes
Sourced from @typescript-eslint/eslint-plugin's releases.
Changelog
Sourced from @typescript-eslint/eslint-plugin's changelog.
Commits
9a6e546chore(release): publish 8.69.0513638efix(eslint-plugin): [no-meaningless-void-operator] report void on non-call ex...1dba4c5chore(eslint-plugin): fixeslint-plugin/require-test-error-positionsreport...a2fccaefix(eslint-plugin): [unified-signatures] compare type parameters by constrain...a23069dtest(eslint-plugin): [no-mixed-enums] add error positions (#12779)3f0dffdfix(eslint-plugin): [no-mixed-enums] use scope analysis instead of type check...e18fea8test(eslint-plugin): [no-floating-promises] reactivate skippednode:testsp...324515ctest(eslint-plugin): [no-unnecessary-condition] add tests for optional chains...2a387f1feat(eslint-plugin): [no-misused-promises] add flagUnions option for checkCon...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)