Skip to content

[AKS] az aks nodepool add/update: Add --enable-managed-dranet - #10266

Merged
Julie Zhu (yanzhudd) merged 3 commits into
Azure:mainfrom
rbtr:rbtr/dranet-preview-cli
Sep 2, 2026
Merged

[AKS] az aks nodepool add/update: Add --enable-managed-dranet#10266
Julie Zhu (yanzhudd) merged 3 commits into
Azure:mainfrom
rbtr:rbtr/dranet-preview-cli

Conversation

@rbtr

@rbtr Evan Baker (rbtr) commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ❌ Action needed

Breaking Changes
❌ 1
❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter enable_managed_dranet
⚠️ 1006 - ParaAdd aks nodepool update cmd aks nodepool update added parameter enable_managed_dranet

Related command

az aks nodepool add
az aks nodepool update

Description

Adds the preview --enable-managed-dranet flag to AKS node pool create and update commands. When specified, the command sends networkProfile.dranet.mode=Managed through the existing 2026-06-02-preview vendored SDK; when omitted during update, the existing DRANET profile is preserved.

This bumps aks-preview to 22.0.0b6 so the option can ship on the extension release cadence. The companion stable implementation is staged in rbtr/azure-cli:rbtr/dranet-stable-cli for the core CLI release train.

Validation

  • azdev style aks-preview
  • azdev linter --include-whl-extensions aks-preview --min-severity medium
  • azdev test azext_aks_preview -a -k managed_dranet
  • python scripts/ci/test_index.py -q

General Guidelines

  • The extension version conforms to the extension version schema.
  • src/index.json is unchanged; publication automation will update it after merge.

Copilot AI lite review requested due to automatic review settings August 27, 2026 17:54
@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Evan Baker (@rbtr),
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new preview flag --enable-managed-dranet to az aks nodepool add and az aks nodepool update in the aks-preview extension, wiring it through the decorator pipeline so the request sets networkProfile.dranet.mode=Managed using the vendored 2026-06-02-preview SDK. It also bumps the extension version and updates docs/tests accordingly.

Changes:

  • Add --enable-managed-dranet parameter to nodepool add/update, and set AgentPoolNetworkProfile.dranet.mode="Managed" when enabled.
  • Update help text and changelog entry for the new preview feature.
  • Add unit tests covering context/getter behavior and decorator network profile setup/update behavior for Managed DRANET.
Show a summary per file
File Description
src/aks-preview/setup.py Bumps aks-preview version to 22.0.0b6.
src/aks-preview/HISTORY.rst Adds release notes entry documenting the new preview flag.
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py Adds tests for managed DRANET context/getter and decorator network profile behavior.
src/aks-preview/azext_aks_preview/custom.py Adds enable_managed_dranet to nodepool add/update command function signatures and passes through locals() into decorators.
src/aks-preview/azext_aks_preview/agentpool_decorator.py Implements getter and sets network_profile.dranet to Managed during add/update flows.
src/aks-preview/azext_aks_preview/_params.py Registers enable_managed_dranet CLI argument for nodepool add/update.
src/aks-preview/azext_aks_preview/_help.py Documents --enable-managed-dranet for nodepool add/update help.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread src/aks-preview/azext_aks_preview/agentpool_decorator.py Outdated
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@FumingZhang FumingZhang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread src/aks-preview/azext_aks_preview/agentpool_decorator.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

FumingZhang
FumingZhang previously approved these changes Sep 1, 2026
@yanzhudd

Copy link
Copy Markdown
Contributor

please resolve the code conflicts.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@yanzhudd
Julie Zhu (yanzhudd) merged commit c09ce13 into Azure:main Sep 2, 2026
24 checks passed
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ aks-preview-22.0.0b6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=179261014&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants