crg support for machines - #10281
Conversation
|
Hi Erin Borders (@erinborders), |
There was a problem hiding this comment.
Pull request overview
This PR adds preview support for associating an AKS machine with an Azure Capacity Reservation Group (CRG) via a new --crg-id argument on az aks machine add, wiring it through machine construction and documenting/testing the behavior in the aks-preview extension.
Changes:
- Add
--crg-id(preview) toaz aks machine addargument surface and help. - Populate
MachineProperties.capacity_reservationwhencrg_idis provided. - Add unit tests covering set/omit behavior for regular machines and rejection for FlexNodes pools.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/HISTORY.rst | Notes the new preview --crg-id support for az aks machine add. |
| src/aks-preview/azext_aks_preview/tests/latest/test_custom.py | Adds unit tests for setting/omitting capacity reservation and validates FlexNodes rejection + argument surface. |
| src/aks-preview/azext_aks_preview/machine.py | Wires crg_id into constructed MachineProperties.capacity_reservation. |
| src/aks-preview/azext_aks_preview/custom.py | Adds crg_id parameter to aks_machine_add and passes through via raw_parameters. |
| src/aks-preview/azext_aks_preview/_params.py | Exposes crg_id on aks machine add with validate_crg_id and preview flag. |
| src/aks-preview/azext_aks_preview/_help.py | Documents --crg-id for aks machine add. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thank you for your contribution Erin Borders (@erinborders)! We will review the pull request and get back to you soon. |
|
AKS |
|
Please resolve the failed linter check by adding a new entry to
|
🤖 PR Validation — ❌ Action needed
❌Azure CLI Extensions Breaking Change Test
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.