[ARO] az aro: Remove old test files and recordings - #33984
Open
Adam Price (komidore64) wants to merge 1 commit into
Open
[ARO] az aro: Remove old test files and recordings#33984Adam Price (komidore64) wants to merge 1 commit into
az aro: Remove old test files and recordings#33984Adam Price (komidore64) wants to merge 1 commit into
Conversation
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
August 25, 2026 14:22
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution Adam Price (@komidore64)! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the az aro command module’s test suite by removing legacy/duplicate test modules and an outdated recording, aligning tests/recordings with the newer unit/ and integration/ layout under aro/tests/latest/.
Changes:
- Deleted legacy validator unit tests (
test_validators.py,test_dynamic_validators.py) from the old location. - Removed legacy helper and scenario test files (
test_aro_helpers.py,test_aro_scenario.py) from the old location. - Deleted an old test recording (
test_aro_get_versions.yaml) from the old recordings path.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/aro/tests/latest/test_validators.py | Removes legacy/duplicate validator unit tests from the old test location. |
| src/azure-cli/azure/cli/command_modules/aro/tests/latest/test_dynamic_validators.py | Removes legacy/duplicate dynamic validator unit tests from the old test location. |
| src/azure-cli/azure/cli/command_modules/aro/tests/latest/test_aro_scenario.py | Removes legacy scenario test from the old test location. |
| src/azure-cli/azure/cli/command_modules/aro/tests/latest/test_aro_helpers.py | Removes legacy helper unit test from the old test location. |
| src/azure-cli/azure/cli/command_modules/aro/tests/latest/recordings/test_aro_get_versions.yaml | Removes an old recording from the legacy recordings directory. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Caden Marchese (cadenmarchese)
approved these changes
Aug 25, 2026
Collaborator
|
ARO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
Description
Remove old test files and recordings
Testing Guide
History Notes
[ARO]
az aro: Remove old test files and recordingsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.